-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover][Extension] Document Viewer #185940
[Discover][Extension] Document Viewer #185940
Conversation
/ci |
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look and work great! I'll have some minor conflicts to resolve in #185905 once this is merged since I've removed example_profiles.tsx
, but should be pretty straightforward. Thanks and LGTM 👍
I would like us to add some example functional tests for this once #185905 is merged though, so I'd recommend we either don't resolve #184084 until those are added, or create a followup issue specifically for the functional tests. Either way is fine for me.
Thanks, @davismcphee, for the review! I am going to add functional tests separately #186265 as this PR is otherwise delaying #175787 |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @jughosta |
Summary
This PR adds extension points to Doc Viewer flyout:
title
docViewsRegistry
.Example:
Checklist