Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Do not retry model deployment #185012

Merged
merged 4 commits into from
Jun 13, 2024
Merged

[ML] Do not retry model deployment #185012

merged 4 commits into from
Jun 13, 2024

Conversation

jgowdyelastic
Copy link
Member

When deploying a trained model, we should not attempt retries as the deployment may take longer than the es client's default 30s timeout.

@jgowdyelastic jgowdyelastic self-assigned this Jun 7, 2024
@jgowdyelastic jgowdyelastic marked this pull request as ready for review June 7, 2024 13:49
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner June 7, 2024 13:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@jgowdyelastic jgowdyelastic enabled auto-merge (squash) June 11, 2024 14:29
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@jgowdyelastic jgowdyelastic merged commit 0486de7 into elastic:main Jun 13, 2024
21 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 13, 2024
@spong spong mentioned this pull request Jun 13, 2024
Closed
@szabosteve szabosteve changed the title [ML] Do not retry model deployment. [ML] Do not retry model deployment Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@darnautov darnautov darnautov approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
backport:skip This commit does not require backporting Feature:3rd Party Models ML 3rd party models :ml release_note:fix v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jgowdyelastic @elasticmachine @kibana-ci @darnautov @peteharverson @kibanamachine