Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Clean up buildDataTableRecordList signature #184976

Conversation

davismcphee
Copy link
Contributor

Summary

This PR cleans up the buildDataTableRecordList function signature to take in an options object instead of multiple params.

Checklist

For maintainers

@davismcphee davismcphee added release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Jun 7, 2024
@davismcphee davismcphee self-assigned this Jun 7, 2024
@davismcphee
Copy link
Contributor Author

/ci

@davismcphee davismcphee force-pushed the update-build-data-table-record-list-signature branch from 4e804b6 to 0c9310d Compare June 10, 2024 22:34
@davismcphee
Copy link
Contributor Author

/ci

@davismcphee davismcphee marked this pull request as ready for review June 11, 2024 00:15
@davismcphee davismcphee requested review from a team as code owners June 11, 2024 00:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

Copy link
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

packages/kbn-discover-utils/src/utils/build_data_record.ts Outdated Show resolved Hide resolved
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Jun 11, 2024
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obs ux management changes LGTM

@kibana-ci
Copy link
Collaborator

kibana-ci commented Jun 12, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/discover-utils 86 88 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 809.2KB 809.2KB +31.0B
slo 860.5KB 860.5KB +33.0B
total +64.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @davismcphee

@davismcphee davismcphee merged commit 4f8cc78 into elastic:main Jun 12, 2024
28 checks passed
@davismcphee davismcphee deleted the update-build-data-table-record-list-signature branch June 12, 2024 15:27
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants