Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stateful sidenav] Add cloud yml setting for onboarding default solution #184808

Merged

Conversation

sebelga
Copy link
Contributor

@sebelga sebelga commented Jun 5, 2024

In this PR I've exposed a new yml setting from the cloud plugin to forward the use case (solution) selected by the user during deployment onboarding creation.

The use case in Cloud is not typed and any string can be provided. From what @AlexP-Elastic found out, the current values passed are: "elasticsearch", "observability", "security", "Security" (uppercase).

I handled the case and ignored any string that does not match one of the known values.
For consistency I mapped the value to the Kibana naming: "es", "oblt" and "security".

New yml setting

# Allowed values: elasticsearch | observability | security
xpack.cloud.onboarding.default_solution: elasticsearch

Update cloud API

The defaultSolution value is exposed by the cloud plugin setup contract (both server and public) under onboarding.

{
  ...,
  onboarding: {
    defaultSolution: 'es', // es, oblt, security
  }
}

This value will have to be read by the security team when creating the default space on new deployment. cc @legrego

@sebelga
Copy link
Contributor Author

sebelga commented Jun 5, 2024

/ci

1 similar comment
@sebelga
Copy link
Contributor Author

sebelga commented Jun 6, 2024

/ci

@sebelga sebelga self-assigned this Jun 6, 2024
@sebelga sebelga added Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) Feature:Chrome Core's Chrome UI (sidenav, header, breadcrumbs) labels Jun 6, 2024
@sebelga sebelga force-pushed the stateful-sidenav/add-cloud-yml-setting branch from e8001d5 to 6f83f64 Compare June 6, 2024 13:08
@sebelga
Copy link
Contributor Author

sebelga commented Jun 6, 2024

/ci

@sebelga sebelga marked this pull request as ready for review June 6, 2024 13:41
@sebelga sebelga requested review from a team as code owners June 6, 2024 13:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in test/plugin_functional/test_suites/core_plugins/rendering.ts LGTM.

@sebelga sebelga requested a review from a team as a code owner June 6, 2024 14:42
@sebelga sebelga added the release_note:skip Skip the PR/issue when compiling release notes label Jun 6, 2024
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet codeowners

@sebelga sebelga requested a review from a team as a code owner June 6, 2024 15:39
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Jun 6, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@sebelga sebelga enabled auto-merge (squash) June 6, 2024 15:53
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cloud 11 12 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
cloud 17 19 +2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cloud 6.3KB 6.6KB +371.0B
Unknown metric groups

API count

id before after diff
cloud 74 78 +4

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sebelga

@sebelga sebelga merged commit 667a9d3 into elastic:main Jun 6, 2024
23 checks passed
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels Jun 6, 2024
@sebelga sebelga deleted the stateful-sidenav/add-cloud-yml-setting branch June 6, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Chrome Core's Chrome UI (sidenav, header, breadcrumbs) release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants