-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Stateful sidenav] Add cloud yml setting for onboarding default solution #184808
[Stateful sidenav] Add cloud yml setting for onboarding default solution #184808
Conversation
/ci |
1 similar comment
/ci |
e8001d5
to
6f83f64
Compare
/ci |
Pinging @elastic/appex-sharedux (Team:SharedUX) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in test/plugin_functional/test_suites/core_plugins/rendering.ts
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fleet codeowners
Pinging @elastic/fleet (Team:Fleet) |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Public APIs missing comments
Page load bundle
History
To update your PR or re-run it, just comment with: cc @sebelga |
In this PR I've exposed a new
yml
setting from thecloud
plugin to forward the use case (solution) selected by the user during deployment onboarding creation.The use case in Cloud is not typed and any string can be provided. From what @AlexP-Elastic found out, the current values passed are: "elasticsearch", "observability", "security", "Security" (uppercase).
I handled the case and ignored any string that does not match one of the known values.
For consistency I mapped the value to the Kibana naming: "es", "oblt" and "security".
New
yml
settingUpdate
cloud
APIThe
defaultSolution
value is exposed by thecloud
plugin setup contract (both server and public) underonboarding
.This value will have to be read by the security team when creating the default space on new deployment. cc @legrego