[data views editor] Disable loading rollups when rollups are disabled #184765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattkime
changed the title
mattkime
added
Team:DataDiscovery
|
/ci |
mattkime
changed the title
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
|
/ci |
lukasolson
approved these changes
Jun 5, 2024
src/plugins/data_view_editor/public/data_view_editor_service.test.ts
Outdated
Show resolved
Hide resolved
…est.ts Co-authored-by: Lukas Olson <[email protected]>
|
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @mattkime |
kibanamachine
added
v8.15.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously we were checking the
/api/rollup/indicesendpoint when the data view editor was loaded. If rollups were disabled, it would harmlessly handle a 404 error. Still, people justifiably wonder whether something is wrong.This PR skips checking the endpoint as one would expect. A unit test has been added. I also manually verified the behavior is as expected.
Follow up to #162674