[ML] AIOps Log Rate Analysis: adds controls for controlling which columns will be visible #184262
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -41,14 +41,19 @@ import { useLogRateAnalysisStateContext } from '@kbn/aiops-components'; | |
|
|
||
| import { useAiopsAppContext } from '../../hooks/use_aiops_app_context'; | ||
| import { useDataSource } from '../../hooks/use_data_source'; | ||
| import { | ||
| commonColumns, | ||
| significantItemColumns, | ||
| } from '../log_rate_analysis_results_table/use_columns'; | ||
|
|
||
| import { | ||
| getGroupTableItems, | ||
| LogRateAnalysisResultsTable, | ||
| LogRateAnalysisResultsGroupsTable, | ||
| } from '../log_rate_analysis_results_table'; | ||
|
|
||
| import { ItemFilterPopover as FieldFilterPopover } from './item_filter_popover'; | ||
| import { ItemFilterPopover as ColumnFilterPopover } from './item_filter_popover'; | ||
| import { LogRateAnalysisTypeCallOut } from './log_rate_analysis_type_callout'; | ||
|
|
||
| const groupResultsMessage = i18n.translate( | ||
|
|
@@ -77,6 +82,37 @@ const groupResultsOnMessage = i18n.translate( | |
| ); | ||
| const resultsGroupedOffId = 'aiopsLogRateAnalysisGroupingOff'; | ||
| const resultsGroupedOnId = 'aiopsLogRateAnalysisGroupingOn'; | ||
| const fieldFilterHelpText = i18n.translate('xpack.aiops.logRateAnalysis.page.fieldFilterHelpText', { | ||
| defaultMessage: | ||
| 'Deselect non-relevant fields to remove them from groups and click the Apply button to rerun the grouping. Use the search bar to filter the list, then select/deselect multiple fields with the actions below.', | ||
| }); | ||
| const columnsFilterHelpText = i18n.translate( | ||
| 'xpack.aiops.logRateAnalysis.page.columnsFilterHelpText', | ||
| { | ||
| defaultMessage: 'Configure visible columns.', | ||
| } | ||
| ); | ||
| const disabledFieldFilterApplyButtonTooltipContent = i18n.translate( | ||
| 'xpack.aiops.analysis.fieldSelectorNotEnoughFieldsSelected', | ||
| { | ||
| defaultMessage: 'Grouping requires at least 2 fields to be selected.', | ||
| } | ||
| ); | ||
| const disabledColumnFilterApplyButtonTooltipContent = i18n.translate( | ||
| 'xpack.aiops.analysis.columnSelectorNotEnoughColumnsSelected', | ||
| { | ||
| defaultMessage: 'At least one column must be selected.', | ||
| } | ||
| ); | ||
| const columnSearchAriaLabel = i18n.translate('xpack.aiops.analysis.columnSelectorAriaLabel', { | ||
| defaultMessage: 'Filter columns', | ||
| }); | ||
| const columnsButton = i18n.translate('xpack.aiops.logRateAnalysis.page.columnsFilterButtonLabel', { | ||
| defaultMessage: 'Columns', | ||
| }); | ||
| const fieldsButton = i18n.translate('xpack.aiops.analysis.fieldFilterButtonLabel', { | ||
| defaultMessage: 'Filter fields', | ||
| }); | ||
|
|
||
| /** | ||
| * Interface for log rate analysis results data. | ||
|
|
@@ -157,6 +193,7 @@ export const LogRateAnalysisResults: FC<LogRateAnalysisResultsProps> = ({ | |
| ); | ||
| const [shouldStart, setShouldStart] = useState(false); | ||
| const [toggleIdSelected, setToggleIdSelected] = useState(resultsGroupedOffId); | ||
| const [skippedColumns, setSkippedColumns] = useState<string[]>(['p-value']); | ||
|
There was a problem hiding this comment. It would be nice if this could be There was a problem hiding this comment. Updated in c1876b9 |
||
|
|
||
| const onGroupResultsToggle = (optionId: string) => { | ||
| setToggleIdSelected(optionId); | ||
|
|
@@ -179,6 +216,10 @@ export const LogRateAnalysisResults: FC<LogRateAnalysisResultsProps> = ({ | |
| startHandler(true, false); | ||
| }; | ||
|
|
||
| const onVisibleColumnsChange = (columns: string[]) => { | ||
| setSkippedColumns(columns); | ||
| }; | ||
|
|
||
| const { | ||
| cancel, | ||
| start, | ||
|
|
@@ -380,10 +421,32 @@ export const LogRateAnalysisResults: FC<LogRateAnalysisResultsProps> = ({ | |
| <FieldFilterPopover | ||
| disabled={!groupResults || isRunning} | ||
| disabledApplyButton={isRunning} | ||
| disabledApplyTooltipContent={disabledFieldFilterApplyButtonTooltipContent} | ||
| helpText={fieldFilterHelpText} | ||
| itemSearchAriaLabel={fieldsButton} | ||
| popoverButtonTitle={fieldsButton} | ||
| uniqueItemNames={uniqueFieldNames} | ||
| onChange={onFieldsFilterChange} | ||
| /> | ||
| </EuiFlexItem> | ||
| <EuiFlexItem grow={false}> | ||
| <ColumnFilterPopover | ||
| disabled={isRunning} | ||
| disabledApplyButton={isRunning} | ||
| disabledApplyTooltipContent={disabledColumnFilterApplyButtonTooltipContent} | ||
| helpText={columnsFilterHelpText} | ||
| itemSearchAriaLabel={columnSearchAriaLabel} | ||
| initialSkippedItems={skippedColumns} | ||
| popoverButtonTitle={columnsButton} | ||
| selectedItemLimit={1} | ||
|
There was a problem hiding this comment. I'm seeing a weird issue where if I open the popover, hit 'Deselect all', I then have to select 2 items (or sometimes more) to get the Apply button enabled: 
There was a problem hiding this comment. Good catch! Fixed this issue in 7f58298 |
||
| uniqueItemNames={ | ||
qn895 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| (groupResults | ||
| ? Object.values(commonColumns) | ||
| : Object.values(significantItemColumns)) as string[] | ||
| } | ||
| onChange={onVisibleColumnsChange} | ||
| /> | ||
| </EuiFlexItem> | ||
| </ProgressControls> | ||
| {showLogRateAnalysisResultsTable && currentAnalysisType !== undefined && ( | ||
| <> | ||
|
|
@@ -481,6 +544,7 @@ export const LogRateAnalysisResults: FC<LogRateAnalysisResultsProps> = ({ | |
| > | ||
| {showLogRateAnalysisResultsTable && groupResults ? ( | ||
| <LogRateAnalysisResultsGroupsTable | ||
| skippedColumns={skippedColumns} | ||
| significantItems={data.significantItems} | ||
| groupTableItems={groupTableItems} | ||
| loading={isRunning} | ||
|
|
@@ -493,6 +557,7 @@ export const LogRateAnalysisResults: FC<LogRateAnalysisResultsProps> = ({ | |
| ) : null} | ||
| {showLogRateAnalysisResultsTable && !groupResults ? ( | ||
| <LogRateAnalysisResultsTable | ||
| skippedColumns={skippedColumns} | ||
| significantItems={data.significantItems} | ||
| loading={isRunning} | ||
| timeRangeMs={timeRangeMs} | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the 'at least one' correct? It seems to require at least two columns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch - fixed in 72f120e