Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HTTP] Make connector APIs public #184068

Merged
merged 2 commits into from
May 23, 2024
Merged

[HTTP] Make connector APIs public #184068

merged 2 commits into from
May 23, 2024

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented May 22, 2024 •
edited by kibanamachine
Loading

Summary

Relates to #180056, #137240

This PR mirrors #183945 to make the same changes for the connectors APIs.

How to test

Per #181277:

  1. Start Elasticsearch (e.g. yarn es snapshot --license trial)
  2. Add server.oas.enabled: true to kibana.dev.yml
  3. Start Kibana (e.g. yarn start --no-base-path)
  4. curl -s -uelastic:changeme http://localhost:5601/api/oas\?pathStartsWith\=/api/actions | jq > test.json

The output will contain summaries like this:

  "paths": {
    "/api/actions/action": {
      "post": {
        "summary": "Create a connector",
        "requestBody": {

@lcawl lcawl added Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) docs v8.14.0 v8.15.0 labels May 22, 2024
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@lcawl lcawl mentioned this pull request May 22, 2024
Open
@lcawl lcawl marked this pull request as ready for review May 23, 2024 00:47
@lcawl lcawl requested a review from a team as a code owner May 23, 2024 00:47
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@lcawl lcawl enabled auto-merge (squash) May 23, 2024 15:20
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl merged commit c86e32c into elastic:main May 23, 2024
18 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 23, 2024
@lcawl
[HTTP] Make connector APIs public (elastic#184068)
7ce7924 
(cherry picked from commit c86e32c)
@kibanamachine kibanamachine mentioned this pull request May 23, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 23, 2024
@kibanamachine @lcawl
[8.14] [HTTP] Make connector APIs public (#184068) (#184155)
75440e0 
# Backport

This will backport the following commits from `main` to `8.14`:
- [[HTTP] Make connector APIs public
(#184068)](#184068)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-05-23T16:34:17Z","message":"[HTTP]
Make connector APIs public
(#184068)","sha":"c86e32c376f43a5a69843deb24761e58f092a2b9","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Alerting","release_note:skip","Team:ResponseOps","docs","v8.14.0","v8.15.0"],"title":"[HTTP]
Make connector APIs
public","number":184068,"url":"https://github.com/elastic/kibana/pull/184068","mergeCommit":{"message":"[HTTP]
Make connector APIs public
(#184068)","sha":"c86e32c376f43a5a69843deb24761e58f092a2b9"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/184068","number":184068,"mergeCommit":{"message":"[HTTP]
Make connector APIs public
(#184068)","sha":"c86e32c376f43a5a69843deb24761e58f092a2b9"}}]}]
BACKPORT-->

Co-authored-by: Lisa Cawley <[email protected]>
@lcawl lcawl deleted the connector-descriptions branch May 23, 2024 22:56
@szaffarano szaffarano mentioned this pull request Jul 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikecote mikecote mikecote approved these changes

Assignees
No one assigned
Labels
docs Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.14.0 v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lcawl @apmmachine @elasticmachine @kibana-ci @kibanamachine @mikecote