[Console Monaco migration] Autocomplete fixes #184032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuliacech
added
Feature:Console
|
/ci |
|
/ci |
|
/ci |
|
/ci |
|
/ci |
|
/ci |
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
ElenaStoeva
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Thanks for patching this up @yuliacech! Tested locally and the fixed autocomplete suggestions worked as expected.
rohanxz
pushed a commit
to honeyn303/kibana
that referenced
this pull request
Jun 4, 2024
## Summary Fixes elastic#183421 This PR fixes following issues in the autocomplete suggestions for request body: - Conditional template - Display suggestions for boolean values - Display async loaded suggestions - Move the cursor inside an empty array/object after inserting it as a template ### How to test - Set the config for Monaco migration `console.dev.enableMonaco: true` in `/config/kibana.dev.yml` - Start ES and Kibana with `yarn es snapshot` and `yarn start` - Conditional template - Try creating different types of repos and check that the "settings" property changes its template for each type <img width="260" alt="Screenshot 2024-05-24 at 17 28 17" src="https://github.com/elastic/kibana/assets/6585477/63ab9951-62b7-4ace-acda-b2cf21737ecf"> <img width="242" alt="Screenshot 2024-05-24 at 17 28 33" src="https://github.com/elastic/kibana/assets/6585477/14c1b65a-8194-4f67-a0f7-e762b19b1566"> - Check autocomplete suggestions of any boolean property, for example for the request `GET _search` the property `explain` - Check asynchronously loaded suggestions, for example `fields` property for the request `GET _search` - Check templates with empty objects/arrays, for example `query` in the `GET _search` request ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #183421
This PR fixes following issues in the autocomplete suggestions for request body:
How to test
Set the config for Monaco migration
console.dev.enableMonaco: truein/config/kibana.dev.ymlStart ES and Kibana with
yarn es snapshotandyarn startConditional template
Check autocomplete suggestions of any boolean property, for example for the request
GET _searchthe propertyexplainCheck asynchronously loaded suggestions, for example
fieldsproperty for the requestGET _searchCheck templates with empty objects/arrays, for example
queryin theGET _searchrequestChecklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers