Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] AIOps Log Rate Analysis: Fixes date picker refresh button #183768

Merged
merged 4 commits into from
May 21, 2024

Conversation

walterra
Copy link
Contributor

@walterra walterra commented May 17, 2024

Summary

Part of #181111.

The refresh button wasn't working as expected. It would refetch the date histogram, but if you had a time set like Last 15 minutes, the time range on the page wasn't updated. This PR adds a fix to trigger a refresh of active bounds. It fixes a problem with the deviation brush not properly updating too. Without the fix, the deviation brush would not move when the time range changes.

aiops-lra-refresh-fix-0001.webm

Checklist

@walterra walterra added release_note:fix :ml Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis v8.15.0 labels May 17, 2024
@walterra walterra self-assigned this May 17, 2024
@walterra walterra requested a review from a team as a code owner May 17, 2024 17:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM ⚡

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested and confirmed brushes now update correctly when using relative dates in the time picker and hitting refresh.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 521.2KB 521.3KB +51.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@walterra walterra merged commit 63441fd into elastic:main May 21, 2024
17 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 21, 2024
@walterra walterra deleted the ml-aiops-fix-refresh branch May 21, 2024 09:35
@szabosteve szabosteve changed the title [ML] AIOps Log Rate Analysis: Fix date picker refresh button. [ML] AIOps Log Rate Analysis: Fixes date picker refresh button Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis :ml release_note:fix v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants