Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable bfetch in serverless #183096

Merged
merged 9 commits into from
May 30, 2024
Merged

Disable bfetch in serverless #183096

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
16fb649
Disable bfetch in serverless
lukasolson May 9, 2024
20cd3da
Merge branch 'main' into srvls/disable-bfetch
lukasolson May 10, 2024
09dada8
Remove setting of bfetch:disable in serverless tests
lukasolson May 10, 2024
87113d0
Merge branch 'main' into srvls/disable-bfetch
lukasolson May 13, 2024
b854c5c
Merge branch 'main' into srvls/disable-bfetch
lukasolson May 14, 2024
2bec2c9
Merge branch 'main' into srvls/disable-bfetch
lukasolson May 15, 2024
bbce7d6
Merge branch 'main' into srvls/disable-bfetch
lukasolson May 20, 2024
4607099
Merge branch 'main' into srvls/disable-bfetch
lukasolson May 28, 2024
a3457d4
Merge branch 'main' into srvls/disable-bfetch
lukasolson May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/serverless.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ xpack.actions.queued.max: 10000
uiSettings:
overrides:
enableESQL: true
bfetch:disable: true

# Task Manager
xpack.task_manager.allow_reading_invalid_state: false
Expand Down
2 changes: 1 addition & 1 deletion x-pack/test_serverless/functional/test_suites/common/discover/group3/_request_counts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
);
await kibanaServer.uiSettings.replace({
defaultIndex: 'logstash-*',
'bfetch:disable': true,
// 'bfetch:disable': true, // bfetch is already disabled in serverless
// TODO: Removed ES|QL setting since ES|QL isn't supported in Serverless
});
await PageObjects.timePicker.setDefaultAbsoluteRangeViaUiSettings();
Expand Down
26 changes: 14 additions & 12 deletions .../test_serverless/functional/test_suites/common/examples/search_examples/search_example.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,20 +20,22 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.svlCommonPage.loginAsAdmin();
});

describe('with bfetch', () => {
testSearchExample();
});
// bfetch is disabled in serverless
// describe('with bfetch', () => {
// testSearchExample();
// });

describe('no bfetch', () => {
const kibanaServer = getService('kibanaServer');
before(async () => {
await kibanaServer.uiSettings.replace({
'bfetch:disable': true,
});
});
after(async () => {
await kibanaServer.uiSettings.unset('bfetch:disable');
});
// No need to disable since it is disabled in serverless.yml
// const kibanaServer = getService('kibanaServer');
// before(async () => {
// await kibanaServer.uiSettings.replace({
// 'bfetch:disable': true,
// });
// });
// after(async () => {
// await kibanaServer.uiSettings.unset('bfetch:disable');
// });

testSearchExample();
});
Expand Down