Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] add typing for function parameters and return #182885

Merged
merged 9 commits into from
May 9, 2024
Merged

[ES|QL] add typing for function parameters and return #182885

merged 9 commits into from
May 9, 2024

Conversation

drewdaemon
Copy link
Contributor

Summary

Preparation for #179634

@drewdaemon
Copy link
Contributor Author

/ci

@drewdaemon drewdaemon added Team:ESQL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Feature:ES|QL ES|QL related features in Kibana labels May 7, 2024
@drewdaemon
Copy link
Contributor Author

/ci

@drewdaemon
Copy link
Contributor Author

/ci

@drewdaemon drewdaemon marked this pull request as ready for review May 8, 2024 00:52
@drewdaemon drewdaemon requested a review from a team as a code owner May 8, 2024 00:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@drewdaemon drewdaemon changed the title [ES|QL] add typing for function parameters [ES|QL] add typing for function parameters and return May 8, 2024
@drewdaemon drewdaemon mentioned this pull request May 9, 2024
Open
7 tasks
@drewdaemon
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/esql-validation-autocomplete 8 10 +2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.1MB 3.1MB +167.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@drewdaemon drewdaemon merged commit a210fce into elastic:main May 9, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

@dej611 dej611 dej611 left review comments

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@drewdaemon @elasticmachine @kibana-ci @dej611 @stratoula @kibanamachine