-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Search] [Playground] Improve UX + fix vector field issue #182342
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joemcelroy
added
release_note:skip
Skip the PR/issue when compiling release notes
Team:EnterpriseSearch
v8.14.0
v8.15.0
labels
May 2, 2024
yansavitski
reviewed
May 2, 2024
x-pack/plugins/search_playground/public/components/view_query/view_query_flyout.tsx
Outdated
Show resolved
Hide resolved
yansavitski
approved these changes
May 2, 2024
…view_query_flyout.tsx
…na into improve-ux-query-context
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 2, 2024
…2342) Improves the experience for Edit context and view query. Now select boxes for context fields ![image](https://github.com/elastic/kibana/assets/49480/6b9c9ef4-2cb1-4bec-9047-9736dbffc34d) and now view query is checkboxes and a label for when fields are hidden ![image](https://github.com/elastic/kibana/assets/49480/6ae4a2a2-41c2-4cbf-8ff9-954910272c4e) Also fixes an issue where if an index has a dense vector field but doesn't have an inference processor setup. we now skip over these type of fields. (cherry picked from commit 8cc8be5)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 8, 2024
…2342) (#182383) # Backport This will backport the following commits from `main` to `8.14`: - [[Search] [Playground] Improve UX + fix vector field issue (#182342)](#182342) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Joe McElroy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-05-02T14:45:07Z","message":"[Search] [Playground] Improve UX + fix vector field issue (#182342)\n\nImproves the experience for Edit context and view query.\r\n\r\nNow select boxes for context fields\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/49480/6b9c9ef4-2cb1-4bec-9047-9736dbffc34d)\r\n\r\nand now view query is checkboxes and a label for when fields are hidden\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/49480/6ae4a2a2-41c2-4cbf-8ff9-954910272c4e)\r\n\r\nAlso fixes an issue where if an index has a dense vector field but\r\ndoesn't have an inference processor setup. we now skip over these type\r\nof fields.","sha":"8cc8be50d75ac64ebe05985c0916aa248a78b61d","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.14.0","v8.15.0"],"title":"[Search] [Playground] Improve UX + fix vector field issue","number":182342,"url":"https://github.com/elastic/kibana/pull/182342","mergeCommit":{"message":"[Search] [Playground] Improve UX + fix vector field issue (#182342)\n\nImproves the experience for Edit context and view query.\r\n\r\nNow select boxes for context fields\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/49480/6b9c9ef4-2cb1-4bec-9047-9736dbffc34d)\r\n\r\nand now view query is checkboxes and a label for when fields are hidden\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/49480/6ae4a2a2-41c2-4cbf-8ff9-954910272c4e)\r\n\r\nAlso fixes an issue where if an index has a dense vector field but\r\ndoesn't have an inference processor setup. we now skip over these type\r\nof fields.","sha":"8cc8be50d75ac64ebe05985c0916aa248a78b61d"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/182342","number":182342,"mergeCommit":{"message":"[Search] [Playground] Improve UX + fix vector field issue (#182342)\n\nImproves the experience for Edit context and view query.\r\n\r\nNow select boxes for context fields\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/49480/6b9c9ef4-2cb1-4bec-9047-9736dbffc34d)\r\n\r\nand now view query is checkboxes and a label for when fields are hidden\r\n\r\n\r\n![image](https://github.com/elastic/kibana/assets/49480/6ae4a2a2-41c2-4cbf-8ff9-954910272c4e)\r\n\r\nAlso fixes an issue where if an index has a dense vector field but\r\ndoesn't have an inference processor setup. we now skip over these type\r\nof fields.","sha":"8cc8be50d75ac64ebe05985c0916aa248a78b61d"}}]}] BACKPORT--> Co-authored-by: Joe McElroy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:skip
Skip the PR/issue when compiling release notes
Team:EnterpriseSearch
v8.14.0
v8.15.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the experience for Edit context and view query.
Now select boxes for context fields
and now view query is checkboxes and a label for when fields are hidden
Also fixes an issue where if an index has a dense vector field but doesn't have an inference processor setup. we now skip over these type of fields.