-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix storybook config #182283
Merged
Merged
Fix storybook config #182283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storybook is attempting to load an esm after the merge of elastic#182244. This updates the webpack configuration to only load files from the browser and main properties.
jbudz
added
Team:Operations
Team label for Operations Team
release_note:skip
Skip the PR/issue when compiling release notes
ci:build-storybooks
labels
May 1, 2024
Pinging @elastic/kibana-operations (Team:Operations) |
Ikuni17
approved these changes
May 1, 2024
mistic
approved these changes
May 1, 2024
mistic
added
the
backport:all-open
Backport to all branches that could still receive a release
label
May 1, 2024
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 1, 2024
Storybook is attempting to load an esm after the merge of elastic#182244. This updates the webpack configuration to only load files from the browser and main properties. (cherry picked from commit 869402b)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 1, 2024
Storybook is attempting to load an esm after the merge of elastic#182244. This updates the webpack configuration to only load files from the browser and main properties. (cherry picked from commit 869402b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 1, 2024
# Backport This will backport the following commits from `main` to `8.14`: - [Fix storybook config (#182283)](#182283) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jon","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-05-01T19:35:08Z","message":"Fix storybook config (#182283)\n\nStorybook is attempting to load an esm after the merge of #182244. This\r\nupdates the webpack configuration to only load files from the browser\r\nand main properties.","sha":"869402b831858240250ceb89bee1929f6cca074c","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport:all-open","ci:build-storybooks","v8.15.0"],"title":"Fix storybook config","number":182283,"url":"https://github.com/elastic/kibana/pull/182283","mergeCommit":{"message":"Fix storybook config (#182283)\n\nStorybook is attempting to load an esm after the merge of #182244. This\r\nupdates the webpack configuration to only load files from the browser\r\nand main properties.","sha":"869402b831858240250ceb89bee1929f6cca074c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/182283","number":182283,"mergeCommit":{"message":"Fix storybook config (#182283)\n\nStorybook is attempting to load an esm after the merge of #182244. This\r\nupdates the webpack configuration to only load files from the browser\r\nand main properties.","sha":"869402b831858240250ceb89bee1929f6cca074c"}}]}] BACKPORT--> Co-authored-by: Jon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:all-open
Backport to all branches that could still receive a release
backported
ci:build-storybooks
release_note:skip
Skip the PR/issue when compiling release notes
Team:Operations
Team label for Operations Team
v8.14.0
v8.15.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storybook is attempting to load an esm after the merge of #182244. This updates the webpack configuration to only load files from the browser and main properties.