Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.14] [Obs AI Assistant] Refactor ObservabilityAIAssistantClient (#181255) #182237

Merged
merged 1 commit into from
May 1, 2024
Merged

[8.14] [Obs AI Assistant] Refactor ObservabilityAIAssistantClient (#181255) #182237

merged 1 commit into from
May 1, 2024

Conversation

dgieselaar
Copy link
Member

Backport

This will backport the following commits from main to 8.14:

Questions ?

Please refer to the Backport tool documentation

@dgieselaar
[Obs AI Assistant] Refactor ObservabilityAIAssistantClient (elastic#1…
3069e4d 
…81255)

Refactors the Observability AI Assistant server-side client. Instead of
using a mix of promises and Observables, we know use Observables where
possible. This leads to more readable code, and makes things like error
handling and logging easier.

This refactor purposely leaves the existing tests in place as much as
possible. The functionality has however been broken into separate
functions so we should be able to break up the existing tests into
smaller pieces.

---------

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 6eba595)
@dgieselaar dgieselaar enabled auto-merge (squash) May 1, 2024 11:23
@dgieselaar dgieselaar mentioned this pull request May 1, 2024
Merged
@botelastic botelastic bot added the Team:Obs AI Assistant Observability AI Assistant label May 1, 2024
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityAIAssistant 17.5KB 17.5KB +7.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
observabilityAIAssistant 24 25 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observabilityAIAssistant 46.2KB 46.2KB +17.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
observabilityAIAssistant 5 6 +1

Total ESLint disabled count

id before after diff
observabilityAIAssistant 8 9 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dgieselaar dgieselaar merged commit 95e97f1 into elastic:8.14 May 1, 2024
22 checks passed
@szaffarano szaffarano mentioned this pull request Jul 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
backport Team:Obs AI Assistant Observability AI Assistant
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dgieselaar @apmmachine @kibana-ci @sorenlouv