Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serverless Search] Improve awareness on using pipelines #182177

Merged
merged 17 commits into from
May 3, 2024
Merged

[Serverless Search] Improve awareness on using pipelines #182177

merged 17 commits into from
May 3, 2024

Conversation

saarikabhasi
Copy link
Member

@saarikabhasi saarikabhasi commented Apr 30, 2024 •
edited
Loading

Summary

  • Adds a section for Preprocessing data

    • home page
    • new connector ->connect to index tab

  • Remove Transform and enrich your data from home page

Screen Recording

Screen.Recording.2024-04-30.at.1.16.01.PM.mov

Checklist

Delete any items that are not applicable to this PR.

@saarikabhasi saarikabhasi added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.15.0 labels Apr 30, 2024
@saarikabhasi saarikabhasi requested a review from a team April 30, 2024 17:10
TattdCodeMonkey
TattdCodeMonkey requested changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@TattdCodeMonkey TattdCodeMonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @leemthompo to review copy

packages/kbn-search-api-panels/components/preprocess_data.tsx Outdated
<EuiSpacer size="s" />
<EuiText>
<p>
<EuiLink href={'#'} target="_blank">
Copy link
Contributor

@TattdCodeMonkey TattdCodeMonkey Apr 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this is for serverless we will need to populate all links before we can merge. We have to assume any commit can go to production.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I agree

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated all links - d9281e6

packages/kbn-search-api-panels/components/preprocess_data.tsx Outdated Show resolved Hide resolved
...ss_search/public/application/components/connectors/connector_config/connector_index_name.tsx Outdated
{i18n.translate(
'xpack.serverlessSearch.connectors.config.preprocessData.clientIngestionPipeline',
{
defaultMessage: 'search-default-ingestion',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is the name of the default ingest pipeline I think we should

  1. use a constant for it
  2. we should not translate it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use code format too?

search-default-ingestion

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 59e464a

@JoseLuisGJ
Copy link
Contributor

@saarikabhasi I see the padding within the icons too small. Consider take a look to this specs:

CleanShot 2024-05-02 at 12 06 52@2x

@saarikabhasi saarikabhasi requested a review from a team as a code owner May 2, 2024 14:17
@saarikabhasi
Copy link
Member Author

@leemthompo updated copy changes in d80d267

@saarikabhasi
Copy link
Member Author

@elasticmachine merge upstream

@saarikabhasi saarikabhasi requested a review from JoseLuisGJ May 2, 2024 19:27
leemthompo
leemthompo approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy and Doclinks LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 2268 2269 +1
indexManagement 654 655 +1
serverlessSearch 316 318 +2
total +4

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/search-api-panels 82 84 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.7MB 2.7MB +6.0B
indexManagement 654.8KB 654.8KB -6.0B
lists 141.2KB 141.6KB +396.0B
serverlessSearch 466.1KB 470.8KB +4.7KB
total +5.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 407.1KB 407.5KB +396.0B
serverlessSearch 19.2KB 19.6KB +435.0B
total +831.0B
Unknown metric groups

API count

id before after diff
@kbn/search-api-panels 82 84 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

TattdCodeMonkey
TattdCodeMonkey approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@TattdCodeMonkey TattdCodeMonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything here LGTM

packages/kbn-search-api-panels/components/preprocess_data.tsx Outdated Show resolved Hide resolved
@saarikabhasi saarikabhasi merged commit 63dfc7d into elastic:main May 3, 2024
19 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 3, 2024
@saarikabhasi saarikabhasi deleted the data-preprocessing branch May 3, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leemthompo leemthompo leemthompo approved these changes

@JoseLuisGJ JoseLuisGJ JoseLuisGJ approved these changes

@TattdCodeMonkey TattdCodeMonkey TattdCodeMonkey approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@saarikabhasi @JoseLuisGJ @kibana-ci @TattdCodeMonkey @leemthompo @kibanamachine