Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Single Metric Viewer: ensures chart displays correctly when opening from a job annotation #182176

Merged
merged 3 commits into from
May 1, 2024
Merged

[ML] Single Metric Viewer: ensures chart displays correctly when opening from a job annotation #182176

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2d4185a
ensure chart focus zoom is set correctly
alvarezmelissa87 Apr 29, 2024
d614c66
remove unnecessary previous forecast id check
alvarezmelissa87 May 1, 2024
df1ea8f
Merge branch 'main' into ml-annotations-to-smv-fix
kibanamachine May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions x-pack/plugins/ml/public/application/timeseriesexplorer/timeseriesexplorer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,9 +463,8 @@ export class TimeSeriesExplorer extends React.Component {
if (
// If the user's focus range is not defined (i.e. no 'zoom' parameter restored from the appState URL),
// then calculate the default focus range to use
zoom === undefined &&
(focusRange === undefined ||
this.previousSelectedForecastId !== this.props.selectedForecastId)
zoom === undefined ||
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fixing the bug when coming in from an annotation, but the issue fixed by #176969 is happening again where the zoom is not restored if the URL contains a forecastId and zoom parameters.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this is fixed by d614c66

focusRange === undefined
) {
focusRange = this.mlTimeSeriesExplorer.calculateDefaultFocusRange(
autoZoomDuration,
Expand All @@ -476,10 +475,12 @@ export class TimeSeriesExplorer extends React.Component {
this.previousSelectedForecastId = this.props.selectedForecastId;
}

this.contextChartSelected({
from: focusRange[0],
to: focusRange[1],
});
if (focusRange !== undefined) {
this.contextChartSelected({
from: focusRange[0],
to: focusRange[1],
});
}
}

this.setState(stateUpdate);
Expand Down