-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Add missing totalSeconds field #182093
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/ci |
delanni
added
release_note:skip
Skip the PR/issue when compiling release notes
v8.14.0
v8.15.0
labels
Apr 30, 2024
cauemarcondes
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing it @delanni
botelastic
bot
added
the
ci:project-deploy-observability
Create an Observability project
label
Apr 30, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 30, 2024
## Summary The PR elastic#182001 was verified at a point where typechecking was missing for a bit, this allowed a missing field to slip in. This PR tries to fix it. (cherry picked from commit 370a7f5)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
kibanamachine
added a commit
that referenced
this pull request
Apr 30, 2024
# Backport This will backport the following commits from `main` to `8.14`: - [[Fix] Add missing totalSeconds field (#182093)](#182093) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alex Szabo","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-04-30T10:09:02Z","message":"[Fix] Add missing totalSeconds field (#182093)\n\n## Summary\r\nThe PR #182001 was verified at a\r\npoint where typechecking was missing for a bit, this allowed a missing\r\nfield to slip in. This PR tries to fix it.","sha":"370a7f5ec625fec1d082b331bfe431b68ed63688","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","ci:project-deploy-observability","v8.14.0","v8.15.0"],"title":"[Fix] Add missing totalSeconds field","number":182093,"url":"https://github.com/elastic/kibana/pull/182093","mergeCommit":{"message":"[Fix] Add missing totalSeconds field (#182093)\n\n## Summary\r\nThe PR #182001 was verified at a\r\npoint where typechecking was missing for a bit, this allowed a missing\r\nfield to slip in. This PR tries to fix it.","sha":"370a7f5ec625fec1d082b331bfe431b68ed63688"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/182093","number":182093,"mergeCommit":{"message":"[Fix] Add missing totalSeconds field (#182093)\n\n## Summary\r\nThe PR #182001 was verified at a\r\npoint where typechecking was missing for a bit, this allowed a missing\r\nfield to slip in. This PR tries to fix it.","sha":"370a7f5ec625fec1d082b331bfe431b68ed63688"}}]}] BACKPORT--> Co-authored-by: Alex Szabo <[email protected]>
mbondyra
pushed a commit
to mbondyra/kibana
that referenced
this pull request
May 2, 2024
## Summary The PR elastic#182001 was verified at a point where typechecking was missing for a bit, this allowed a missing field to slip in. This PR tries to fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
apm:review
ci:project-deploy-observability
Create an Observability project
release_note:skip
Skip the PR/issue when compiling release notes
v8.14.0
v8.15.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The PR #182001 was verified at a point where typechecking was missing for a bit, this allowed a missing field to slip in. This PR tries to fix it.