-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Move state management and data fetching code to new folders #182063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davismcphee
added
release_note:skip
Skip the PR/issue when compiling release notes
Team:DataDiscovery
Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
labels
Apr 30, 2024
/ci |
1 similar comment
/ci |
davismcphee
force-pushed
the
discover-split-up-utils
branch
from
April 30, 2024 03:11
eeeca4d
to
73cde40
Compare
/ci |
davismcphee
force-pushed
the
discover-split-up-utils
branch
from
April 30, 2024 13:21
73cde40
to
1872c64
Compare
/ci |
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
davismcphee
force-pushed
the
discover-split-up-utils
branch
from
May 1, 2024 15:35
1872c64
to
935be23
Compare
davismcphee
force-pushed
the
discover-split-up-utils
branch
from
May 1, 2024 15:47
935be23
to
4b03956
Compare
mattkime
approved these changes
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code changes look good and work well. Thanks for breaking apart a larger pr.
kqualters-elastic
approved these changes
May 3, 2024
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @davismcphee |
kibanamachine
added
v8.15.0
backport:skip
This commit does not require backporting
labels
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
Team:DataDiscovery
Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
v8.15.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These commits are split out from my working branch for #181963 to make reviewing easier.
Our state management code is currently split between a folder called
services
and theutils
folder. This makes working with the code more difficult, especially where One Discover will soon introduce additional complexity. To make the state management code easier to work with, I moved all of the related files into a single folder calledstate_management
with autils
subfolder for its utility functions.Similarly, all of our data fetching code was spread between files in the
utils
folder. For the same reason, I moved these files into a new folder calleddata_fetching
, since they will also undergo a lot of changes for One Discover.Part of #181963.
Checklist
For maintainers