Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Move state management and data fetching code to new folders #182063

Merged
merged 6 commits into from
May 3, 2024

Conversation

davismcphee
Copy link
Contributor

Summary

These commits are split out from my working branch for #181963 to make reviewing easier.

Our state management code is currently split between a folder called services and the utils folder. This makes working with the code more difficult, especially where One Discover will soon introduce additional complexity. To make the state management code easier to work with, I moved all of the related files into a single folder called state_management with a utils subfolder for its utility functions.

Similarly, all of our data fetching code was spread between files in the utils folder. For the same reason, I moved these files into a new folder called data_fetching, since they will also undergo a lot of changes for One Discover.

Part of #181963.

Checklist

For maintainers

@davismcphee davismcphee added release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Apr 30, 2024
@davismcphee davismcphee self-assigned this Apr 30, 2024
@davismcphee
Copy link
Contributor Author

/ci

1 similar comment
@davismcphee
Copy link
Contributor Author

/ci

@davismcphee davismcphee force-pushed the discover-split-up-utils branch from eeeca4d to 73cde40 Compare April 30, 2024 03:11
@davismcphee
Copy link
Contributor Author

/ci

@davismcphee davismcphee force-pushed the discover-split-up-utils branch from 73cde40 to 1872c64 Compare April 30, 2024 13:21
@davismcphee
Copy link
Contributor Author

/ci

@davismcphee davismcphee marked this pull request as ready for review April 30, 2024 14:48
@davismcphee davismcphee requested review from a team as code owners April 30, 2024 14:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@davismcphee davismcphee force-pushed the discover-split-up-utils branch from 1872c64 to 935be23 Compare May 1, 2024 15:35
@davismcphee davismcphee force-pushed the discover-split-up-utils branch from 935be23 to 4b03956 Compare May 1, 2024 15:47
Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes look good and work well. Thanks for breaking apart a larger pr.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @davismcphee

@davismcphee davismcphee merged commit 828b5c9 into elastic:main May 3, 2024
35 checks passed
@davismcphee davismcphee deleted the discover-split-up-utils branch May 3, 2024 21:11
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants