[EuiProvider/Security Solution] Remove usage of deprecated modules for mounting React, Part II

[tsullivan]

Summary

Partially addresses https://github.com/elastic/kibana-team/issues/805

These changes come up from searching in the code and finding where certain kinds of deprecated AppEx-SharedUX modules are imported. Reviewers: Please interact with critical paths through the UI components touched in this PR, ESPECIALLY in terms of testing dark mode and i18n.

This is the 2nd PR to focus on code within Security Solution, following #181099.

Note: this also makes inclusion of i18n and analytics dependencies consistent. Analytics is an optional dependency for the SharedUX modules, which wrap KibanaErrorBoundaryProvider and is designed to capture telemetry about errors that are caught in the error boundary.

Checklist

Delete any items that are not applicable to this PR.

• Unit or functional tests were updated or added to match the most common scenarios
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
• This was checked for cross-browser compatibility

[elasticmachine]

Pinging @elastic/security-solution (Team: SecuritySolution)

[elasticmachine]

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

[elasticmachine]

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

[elasticmachine]

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

[elasticmachine]

Pinging @elastic/security-detection-engine (Team:Detection Engine)

[elasticmachine]

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

[ashokaditya]

Did a code review only. LGTM. I would wait for @szwarckonrad or @tomsonpl to verify osquery changes.

[ashokaditya]

Should be safe to remove this unused param

[tsullivan]

18ba8aa

[e40pud]

DE changes LGTM

[PhilippeOberti]

desk tested and code LGTM for the Threat Hunting Investigations team!

[ashokaditya]

Thanks for the changes.

[seanrathier]

Approved.
Tested on local environment.
1 non-blocking question

[seanrathier]

Newbie question: I thought these service were started when Kibana loads the plugins when it starts up since these are CoreStartup services.

Is validating the services have started?
If some of these services are the Notification service dependencies, should that service start it instead of passing them as params?

[tsullivan]

Newbie question: I thought these service were started when Kibana loads the plugins when it starts up since these are CoreStartup services.
Is validating the services have started?

This is a good question.

• The services are started when Kibana loads up. My startServices variable is just a made-up name for a wrapper object of a few specific services that are available in CoreStart.
• This PR focuses on updating the toMountPoint and KibanaRenderContextProvider components, which are owned by SharedUX. They need the analytics, i18n and theme services to be passed in. Rather than using a literal object of { analytics, i18n, theme }, I created a wrapper object, thinking that it's slightly less restrictive - more services could be needed for these components in the future..
• The previous code was only making the notifications service usable for downstream code. This change makes a set of services usable by creating the startServices wrapper object.
• These changes aren't about validating that the services have started.

If you're wondering, how does calling useKibana().services give us access to these services? They were stashed into a context in x-pack/plugins/cloud_security_posture/public/plugin.tsx with <KibanaContextProvider services={{ ...core, ...plugins, storage }}>. Therefore, everything nested under that provider can access these startup services from the context. Calling the hook to get the context saves us from having to pass down the services to every component through props.

If some of these services are the Notification service dependencies, should that service start it instead of passing them as params?

I take this to mean, couldn't we just call useKibana().services to fetch the services from context where they're needed? I chose to stick with the existing coding style and pass them down from here. Also, React hooks can only be called from React components, and showCreateDetectionRuleSuccessToast / showChangeBenchmarkRuleStatesSuccessToast are not React components.

[tsullivan]

@seanrathier while going through the code to address your question, I found a few places that could be cleaned up: e941e01

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: ecb7fcd

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
cloudSecurityPosture	438	453	+15
osquery	336	347	+11
timelines	121	138	+17
total			+43

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
timelines	196	198	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
cloudSecurityPosture	452.6KB	454.7KB	+2.1KB
osquery	1.0MB	1.0MB	-582.0B
securitySolution	13.7MB	13.7MB	+540.0B
threatIntelligence	57.1KB	57.3KB	+259.0B
timelines	30.3KB	32.7KB	+2.4KB
total			+4.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
cloudSecurityPosture	16.1KB	16.3KB	+141.0B
osquery	51.1KB	53.6KB	+2.4KB
timelines	108.9KB	109.3KB	+370.0B
total			+2.9KB

Unknown metric groups

API count

id	before	after	diff
timelines	240	242	+2

References to deprecated APIs

id	before	after	diff
cloudSecurityPosture	9	4	-5
osquery	22	9	-13
timelines	2	0	-2
total			-20

History

• 💔 Build #208288 failed 14ae3bb
• 💚 Build #208249 succeeded f744be2
• 💔 Build #208173 failed 9f28f3c
• 💚 Build #207994 succeeded e4fed33
• 💚 Build #207890 succeeded 18ba8aa

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @tsullivan