-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Transforms: Improves data view checks #181892
Merged
walterra
merged 12 commits into
elastic:main
from
walterra:ml-transform-fix-data-view-checks
May 13, 2024
Merged
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9de1e9e
fix data view checks
walterra 2e6abe5
fix caching
walterra ae18fdf
fix edit button
walterra 9f1b5bf
fix jest test
walterra dec491e
Merge branch 'main' into ml-transform-fix-data-view-checks
walterra 9f23cb8
tweak hook
walterra d9c1c59
Merge branch 'main' into ml-transform-fix-data-view-checks
walterra 2f69ee3
Merge branch 'main' into ml-transform-fix-data-view-checks
walterra 928e66c
tweak caching
walterra e1276c5
Merge branch 'main' into ml-transform-fix-data-view-checks
walterra 761a4fb
Merge branch 'main' into ml-transform-fix-data-view-checks
walterra cac017e
Merge branch 'main' into ml-transform-fix-data-view-checks
walterra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
x-pack/plugins/transform/public/app/hooks/use_get_data_views_title_id_map.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { useQuery } from '@tanstack/react-query'; | ||
|
||
import type { IHttpFetchError } from '@kbn/core-http-browser'; | ||
|
||
import { TRANSFORM_REACT_QUERY_KEYS } from '../../../common/constants'; | ||
|
||
import { useAppDependencies } from '../app_dependencies'; | ||
|
||
type DataViewListTitleIdMap = Record<string, string>; | ||
|
||
export const useGetDataViewsTitleIdMap = () => { | ||
const { data } = useAppDependencies(); | ||
|
||
return useQuery<DataViewListTitleIdMap, IHttpFetchError>( | ||
[TRANSFORM_REACT_QUERY_KEYS.GET_DATA_VIEW_IDS_WITH_TITLE], | ||
async () => { | ||
return (await data.dataViews.getIdsWithTitle(true)).reduce<Record<string, string>>( | ||
(acc, { id, title }) => { | ||
acc[title] = id; | ||
return acc; | ||
}, | ||
{} | ||
); | ||
} | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Total nit pick. but rather than having to rename
data
->dataViewsTitleIdMap
on every use, could it be renamed when being returned fromuseGetDataViewsTitleIdMap
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hook wraps
useQuery
so that whole returned object comes from it anddata
is part of its standard API (likeisLoading
,error
etc.).