[Visualizations] Remove jQuery from owned plugins + remove flot-charts from shared bundle #181543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
|
/ci |
dej611
changed the title
dej611
added
Team:Visualizations
|
/ci |
|
/ci |
|
/ci |
|
/ci |
…bana into fix/jquery-bundle-size
|
/ci |
dej611
changed the title
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
jbudz
approved these changes
Apr 26, 2024
Heenawter
approved these changes
Apr 26, 2024
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
yuliacech
pushed a commit
to yuliacech/kibana
that referenced
this pull request
May 3, 2024
…s from shared bundle (elastic#181543) ## Summary This PR aims to reduce the amount of dependencies used in the visualizations plugins. Dependencies removed: * `jquery` usage in `graph` * `jquery` usage in `Vega` plugin. As a bonus point it makes the `@kbn/flot-charts` dependency a Canvas and Monitoring only (the only 2 consumers) rather than load it for all Kibana plugins. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <[email protected]>
This was referenced Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to reduce the amount of dependencies used in the visualizations plugins.
Dependencies removed:
jqueryusage ingraphjqueryusage inVegaplugin.As a bonus point it makes the
@kbn/flot-chartsdependency a Canvas and Monitoring only (the only 2 consumers) rather than load it for all Kibana plugins.Checklist