[ML] Fixes responsive layout for Trained Models table #181541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darnautov
added
release_note:fix
:ml
Feature:3rd Party Models
|
Pinging @elastic/ml-ui (:ml) |
| @@ -768,7 +767,7 @@ export const ModelsList: FC<Props> = ({ | |||
| <EuiSpacer size="m" /> | |||
| <div data-test-subj="mlModelsTableContainer"> | |||
| <EuiInMemoryTable<ModelItem> | |||
| css={{ overflowX: 'auto' }} | |||
| responsiveBreakpoint={'xl'} | |||
There was a problem hiding this comment.
The downloads text overflows when the width is reduced to below 1200px.
I think this xl limit is too high as 1200px isn't that small. The table is still readable at that width.
Setting this to l rather than xl would be better IMO.
There was a problem hiding this comment.
-
Download action has been fixed in 9436c2f
-
This is how the table looks with the
lbreakpoint. The state column does not look good
There was a problem hiding this comment.
Ok cool. Yeah that overflow was the biggest issue.
I still think 1200px is a bit high of a limit to be switching over to the other view, but I don't feel that strongly about it.
There was a problem hiding this comment.
I also don't have a strong opinion on this, let's ask @qn895 :)
There was a problem hiding this comment.
Testing this, I'm leaning towards sticking with xl.
There was a problem hiding this comment.
I think the screenshot as is looks better for 1200px 👍 If we want to go extra we can do some logic to only show partial info (like maybe just the colored dots) but that's also hiding important information. So for now this LGTM.
peteharverson
requested review from
qn895
and removed request for
peteharverson
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @darnautov |
qn895
approved these changes
Apr 24, 2024
|
LGTM 🎉 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
Apr 24, 2024
## Summary Closes elastic#181530 - Sets percentage width for all columns - Sets responsive breakpoint - Makes Deployment stats table responsive as well  ### Checklist - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) (cherry picked from commit d5999c3) # Conflicts: # x-pack/plugins/ml/public/application/model_management/models_list.tsx
kpatticha
pushed a commit
to kpatticha/kibana
that referenced
this pull request
Apr 26, 2024
## Summary Closes elastic#181530 - Sets percentage width for all columns - Sets responsive breakpoint - Makes Deployment stats table responsive as well  ### Checklist - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
darnautov
added a commit
that referenced
this pull request
May 2, 2024
…181602) # Backport This will backport the following commits from `main` to `8.14`: - [[ML] Fix responsive layout for Trained Models table (#181541)](#181541) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dima Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-04-24T14:29:06Z","message":"[ML] Fix responsive layout for Trained Models table (#181541)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/181530\r\n\r\n- Sets percentage width for all columns\r\n- Sets responsive breakpoint \r\n- Makes Deployment stats table responsive as well \r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"d5999c339a615a4e7cbd23741747dffa984da678","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Feature:3rd Party Models","Team:ML","v8.14.0","v8.15.0"],"number":181541,"url":"https://github.com/elastic/kibana/pull/181541","mergeCommit":{"message":"[ML] Fix responsive layout for Trained Models table (#181541)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/181530\r\n\r\n- Sets percentage width for all columns\r\n- Sets responsive breakpoint \r\n- Makes Deployment stats table responsive as well \r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"d5999c339a615a4e7cbd23741747dffa984da678"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","labelRegex":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/181541","number":181541,"mergeCommit":{"message":"[ML] Fix responsive layout for Trained Models table (#181541)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/181530\r\n\r\n- Sets percentage width for all columns\r\n- Sets responsive breakpoint \r\n- Makes Deployment stats table responsive as well \r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"d5999c339a615a4e7cbd23741747dffa984da678"}}]}] BACKPORT--> Co-authored-by: Kibana Machine <[email protected]>
szabosteve
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #181530
Checklist