Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix maps plugin async route registration #181518

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Fix maps plugin async route registration #181518

merged 2 commits into from
Apr 24, 2024

Conversation

pgayvallet
Copy link
Contributor

Summary

Async registration is bad, especially when promise rejections are not caught.

The PR adapts the routes registration to be synchronous

@pgayvallet
Copy link
Contributor Author

/ci

@pgayvallet pgayvallet added release_note:skip Skip the PR/issue when compiling release notes v8.15.0 labels Apr 24, 2024
@afharo afharo mentioned this pull request Apr 24, 2024
Merged
66 tasks
@pgayvallet
Copy link
Contributor Author

/ci

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet marked this pull request as ready for review April 24, 2024 09:32
@pgayvallet pgayvallet requested a review from a team as a code owner April 24, 2024 09:32
nreese
nreese approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibana-gis changes LGTM. Thanks for making these changes.
code review only

@pgayvallet pgayvallet merged commit 923b10b into elastic:main Apr 24, 2024
16 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 24, 2024
kpatticha pushed a commit to kpatticha/kibana that referenced this pull request Apr 26, 2024
@pgayvallet @kpatticha
Fix maps plugin async route registration (elastic#181518)
f190b19 
## Summary

Async registration is bad, especially when promise rejections are not
caught.

The PR adapts the routes registration to be synchronous
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pgayvallet @kibana-ci @nreese @kibanamachine