[Obs AI Assistant] Hide unavailable connectors #181455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgieselaar
added
release_note:skip
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
dgieselaar
commented
Apr 23, 2024
| includeSystemActionTypes: false, | ||
| }) | ||
| .then((types) => | ||
| types.filter((type) => type.enabled && type.enabledInLicense).map((type) => type.id) |
There was a problem hiding this comment.
@cnasikas there is also enabledInConfig, but I wasn't sure what that means. Do we also need to take it into account?
There was a problem hiding this comment.
Good question. Users can disable connector types in kibana.yml by using the xpack.actions.enabledActionTypes config. By default all types are available. Better to filter them out.
klacabane
approved these changes
Apr 23, 2024
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @dgieselaar |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 24, 2024
Hides unavailable connectors (e.g. due to license mismatches). (cherry picked from commit 214833a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 24, 2024
) # Backport This will backport the following commits from `main` to `8.14`: - [[Obs AI Assistant] Hide unavailable connectors (#181455)](#181455) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dario Gieselaar","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-04-24T09:51:58Z","message":"[Obs AI Assistant] Hide unavailable connectors (#181455)\n\nHides unavailable connectors (e.g. due to license mismatches).","sha":"214833af0bc45dad269529a1904cfbb934da945e","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Obs AI Assistant","v8.14.0","v8.15.0"],"title":"[Obs AI Assistant] Hide unavailable connectors","number":181455,"url":"https://github.com/elastic/kibana/pull/181455","mergeCommit":{"message":"[Obs AI Assistant] Hide unavailable connectors (#181455)\n\nHides unavailable connectors (e.g. due to license mismatches).","sha":"214833af0bc45dad269529a1904cfbb934da945e"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/181455","number":181455,"mergeCommit":{"message":"[Obs AI Assistant] Hide unavailable connectors (#181455)\n\nHides unavailable connectors (e.g. due to license mismatches).","sha":"214833af0bc45dad269529a1904cfbb934da945e"}}]}] BACKPORT--> Co-authored-by: Dario Gieselaar <[email protected]>
kpatticha
pushed a commit
to kpatticha/kibana
that referenced
this pull request
Apr 26, 2024
Hides unavailable connectors (e.g. due to license mismatches).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hides unavailable connectors (e.g. due to license mismatches).