Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Profiling] Adding "estimated value" label on sample columns #181449

Merged
merged 2 commits into from
Apr 24, 2024
Merged

[Profiling] Adding "estimated value" label on sample columns #181449

merged 2 commits into from
Apr 24, 2024

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Apr 23, 2024 •
edited by kibanamachine
Loading

The service samples and transaction samples are estimated values, so I'm adding a tooltip to make it clear for users.

Screenshot 2024-04-23 at 15 51 44

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v8.14.0 labels Apr 23, 2024
@cauemarcondes cauemarcondes requested a review from a team as a code owner April 23, 2024 14:53
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

jennypavlova
jennypavlova approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@jennypavlova jennypavlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

...rvability_solution/profiling/public/components/frame_information_window/apm_transactions.tsx Outdated Show resolved Hide resolved
@cauemarcondes cauemarcondes enabled auto-merge (squash) April 24, 2024 08:48
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #62 / discover/ccs_compatible discover search CCS timeout bfetch enabled timeout on single shard shows warning and results with bfetch enabled

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
profiling 407.6KB 407.9KB +346.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit c17ba8c into elastic:main Apr 24, 2024
19 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 24, 2024
@cauemarcondes
[Profiling] Adding "estimated value" label on sample columns (elastic…
4ebd92f 
…#181449)

The service samples and transaction samples are estimated values, so I'm
adding a tooltip to make it clear for users.

<img width="883" alt="Screenshot 2024-04-23 at 15 51 44"
src="https://github.com/elastic/kibana/assets/55978943/b71284ba-9104-45e5-9546-303279cb11f3">

(cherry picked from commit c17ba8c)
@kibanamachine kibanamachine mentioned this pull request Apr 24, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 24, 2024
@kibanamachine @cauemarcondes
[8.14] [Profiling] Adding &quot;estimated value&quot; label on sample…
4373876 
… columns (#181449) (#181539)

# Backport

This will backport the following commits from `main` to `8.14`:
- [[Profiling] Adding &quot;estimated value&quot; label on sample
columns (#181449)](#181449)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Cauê
Marcondes","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-04-24T10:08:26Z","message":"[Profiling]
Adding \"estimated value\" label on sample columns (#181449)\n\nThe
service samples and transaction samples are estimated values, so
I'm\r\nadding a tooltip to make it clear for users.\r\n\r\n<img
width=\"883\" alt=\"Screenshot 2024-04-23 at 15 51
44\"\r\nsrc=\"https://github.com/elastic/kibana/assets/55978943/b71284ba-9104-45e5-9546-303279cb11f3\">","sha":"c17ba8cd1078a2885fd8baa7ab8c9faaf6e39671","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.14.0","v8.15.0"],"title":"[Profiling]
Adding \"estimated value\" label on sample
columns","number":181449,"url":"https://github.com/elastic/kibana/pull/181449","mergeCommit":{"message":"[Profiling]
Adding \"estimated value\" label on sample columns (#181449)\n\nThe
service samples and transaction samples are estimated values, so
I'm\r\nadding a tooltip to make it clear for users.\r\n\r\n<img
width=\"883\" alt=\"Screenshot 2024-04-23 at 15 51
44\"\r\nsrc=\"https://github.com/elastic/kibana/assets/55978943/b71284ba-9104-45e5-9546-303279cb11f3\">","sha":"c17ba8cd1078a2885fd8baa7ab8c9faaf6e39671"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/181449","number":181449,"mergeCommit":{"message":"[Profiling]
Adding \"estimated value\" label on sample columns (#181449)\n\nThe
service samples and transaction samples are estimated values, so
I'm\r\nadding a tooltip to make it clear for users.\r\n\r\n<img
width=\"883\" alt=\"Screenshot 2024-04-23 at 15 51
44\"\r\nsrc=\"https://github.com/elastic/kibana/assets/55978943/b71284ba-9104-45e5-9546-303279cb11f3\">","sha":"c17ba8cd1078a2885fd8baa7ab8c9faaf6e39671"}}]}]
BACKPORT-->

Co-authored-by: Cauê Marcondes <[email protected]>
kpatticha pushed a commit to kpatticha/kibana that referenced this pull request Apr 26, 2024
@cauemarcondes @kpatticha
[Profiling] Adding "estimated value" label on sample columns (elastic…
4fead54 
…#181449)

The service samples and transaction samples are estimated values, so I'm
adding a tooltip to make it clear for users.

<img width="883" alt="Screenshot 2024-04-23 at 15 51 44"
src="https://github.com/elastic/kibana/assets/55978943/b71284ba-9104-45e5-9546-303279cb11f3">
@szaffarano szaffarano mentioned this pull request Jul 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennypavlova jennypavlova jennypavlova approved these changes

@MiriamAparicio MiriamAparicio MiriamAparicio approved these changes

@crespocarlos crespocarlos crespocarlos approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v8.14.0 v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cauemarcondes @apmmachine @kibana-ci @kibanamachine @crespocarlos @jennypavlova @MiriamAparicio