Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cases] Fix failing test: useCreateCaseModal #181386

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

adcoelho
Copy link
Contributor

Fixes #174205

Summary

The failing test was rendering the opened modal and not doing anything with it. I removed that block and the execution time locally went from 200+ ms to around 4.

@adcoelho adcoelho added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.15.0 labels Apr 23, 2024
@adcoelho adcoelho self-assigned this Apr 23, 2024
@adcoelho adcoelho requested a review from a team as a code owner April 23, 2024 08:38
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

Copy link
Contributor

@js-jankisalvi js-jankisalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch 👍

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @adcoelho

@adcoelho adcoelho merged commit e2c39c9 into elastic:main Apr 24, 2024
18 checks passed
kpatticha pushed a commit to kpatticha/kibana that referenced this pull request Apr 26, 2024
Fixes elastic#174205

## Summary

The failing test was rendering the opened modal and not doing anything
with it. I removed that block and the execution time locally went from
200+ ms to around 4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.15.0
Projects
None yet
4 participants