Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Making job wizard chart endpoints admin only #181329

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Apr 22, 2024

The endpoints used supply the data for charts in the AD job wizards are only ever called internally by admin users and so should have a more appropriate capability level.

@jgowdyelastic jgowdyelastic self-assigned this Apr 22, 2024
@jgowdyelastic jgowdyelastic added non-issue Indicates to automation that a pull request should not appear in the release notes :ml Feature:Anomaly Detection ML anomaly detection release_note:skip Skip the PR/issue when compiling release notes v8.15.0 labels Apr 22, 2024
@jgowdyelastic jgowdyelastic marked this pull request as ready for review April 22, 2024 14:45
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner April 22, 2024 14:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@jgowdyelastic jgowdyelastic merged commit d70d0ee into elastic:main Apr 24, 2024
18 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 24, 2024
The endpoints used supply the data for charts in the AD job wizards are
only ever called internally by admin users and so should have a more
appropriate capability level.

(cherry picked from commit d70d0ee)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 24, 2024
…181640)

# Backport

This will backport the following commits from `main` to `8.14`:
- [[ML] Making job wizard chart endpoints admin only
(#181329)](#181329)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"James
Gowdy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-04-24T21:25:54Z","message":"[ML]
Making job wizard chart endpoints admin only (#181329)\n\nThe endpoints
used supply the data for charts in the AD job wizards are\r\nonly ever
called internally by admin users and so should have a
more\r\nappropriate capability
level.","sha":"d70d0ee168361bc18350c18166610137485ecafb","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["non-issue",":ml","Feature:Anomaly
Detection","release_note:skip","v8.14.0","v8.15.0"],"title":"[ML] Making
job wizard chart endpoints admin
only","number":181329,"url":"https://github.com/elastic/kibana/pull/181329","mergeCommit":{"message":"[ML]
Making job wizard chart endpoints admin only (#181329)\n\nThe endpoints
used supply the data for charts in the AD job wizards are\r\nonly ever
called internally by admin users and so should have a
more\r\nappropriate capability
level.","sha":"d70d0ee168361bc18350c18166610137485ecafb"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/181329","number":181329,"mergeCommit":{"message":"[ML]
Making job wizard chart endpoints admin only (#181329)\n\nThe endpoints
used supply the data for charts in the AD job wizards are\r\nonly ever
called internally by admin users and so should have a
more\r\nappropriate capability
level.","sha":"d70d0ee168361bc18350c18166610137485ecafb"}}]}]
BACKPORT-->

Co-authored-by: James Gowdy <[email protected]>
kpatticha pushed a commit to kpatticha/kibana that referenced this pull request Apr 26, 2024
The endpoints used supply the data for charts in the AD job wizards are
only ever called internally by admin users and so should have a more
appropriate capability level.
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Jun 6, 2024
jgowdyelastic added a commit that referenced this pull request Jun 19, 2024
adelisle pushed a commit to Makila-AI/kibana that referenced this pull request Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Anomaly Detection ML anomaly detection :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes v8.14.0 v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants