-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Making job wizard chart endpoints admin only #181329
Merged
jgowdyelastic
merged 2 commits into
elastic:main
from
jgowdyelastic:making-job-wizard-chart-endpoints-admin-only
Apr 24, 2024
Merged
[ML] Making job wizard chart endpoints admin only #181329
jgowdyelastic
merged 2 commits into
elastic:main
from
jgowdyelastic:making-job-wizard-chart-endpoints-admin-only
Apr 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
added
non-issue
Indicates to automation that a pull request should not appear in the release notes
:ml
Feature:Anomaly Detection
ML anomaly detection
release_note:skip
Skip the PR/issue when compiling release notes
v8.15.0
labels
Apr 22, 2024
Pinging @elastic/ml-ui (:ml) |
peteharverson
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 24, 2024
The endpoints used supply the data for charts in the AD job wizards are only ever called internally by admin users and so should have a more appropriate capability level. (cherry picked from commit d70d0ee)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 24, 2024
…181640) # Backport This will backport the following commits from `main` to `8.14`: - [[ML] Making job wizard chart endpoints admin only (#181329)](#181329) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"James Gowdy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-04-24T21:25:54Z","message":"[ML] Making job wizard chart endpoints admin only (#181329)\n\nThe endpoints used supply the data for charts in the AD job wizards are\r\nonly ever called internally by admin users and so should have a more\r\nappropriate capability level.","sha":"d70d0ee168361bc18350c18166610137485ecafb","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["non-issue",":ml","Feature:Anomaly Detection","release_note:skip","v8.14.0","v8.15.0"],"title":"[ML] Making job wizard chart endpoints admin only","number":181329,"url":"https://github.com/elastic/kibana/pull/181329","mergeCommit":{"message":"[ML] Making job wizard chart endpoints admin only (#181329)\n\nThe endpoints used supply the data for charts in the AD job wizards are\r\nonly ever called internally by admin users and so should have a more\r\nappropriate capability level.","sha":"d70d0ee168361bc18350c18166610137485ecafb"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/181329","number":181329,"mergeCommit":{"message":"[ML] Making job wizard chart endpoints admin only (#181329)\n\nThe endpoints used supply the data for charts in the AD job wizards are\r\nonly ever called internally by admin users and so should have a more\r\nappropriate capability level.","sha":"d70d0ee168361bc18350c18166610137485ecafb"}}]}] BACKPORT--> Co-authored-by: James Gowdy <[email protected]>
kpatticha
pushed a commit
to kpatticha/kibana
that referenced
this pull request
Apr 26, 2024
The endpoints used supply the data for charts in the AD job wizards are only ever called internally by admin users and so should have a more appropriate capability level.
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Jun 6, 2024
jgowdyelastic
added a commit
that referenced
this pull request
Jun 19, 2024
…184914) Manual back port of #181329 Co-authored-by: Kibana Machine <[email protected]>
adelisle
pushed a commit
to Makila-AI/kibana
that referenced
this pull request
Aug 5, 2024
) (elastic#184914) Manual back port of elastic#181329 Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Anomaly Detection
ML anomaly detection
:ml
non-issue
Indicates to automation that a pull request should not appear in the release notes
release_note:skip
Skip the PR/issue when compiling release notes
v8.14.0
v8.15.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The endpoints used supply the data for charts in the AD job wizards are only ever called internally by admin users and so should have a more appropriate capability level.