Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Obs AI assistant] Relax validation on missing fallbacks #181324

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Apr 22, 2024

Summary

Relaxes the validation which means that we can't quick fix the quotes problem but we are still fixing other syntax errors such as functions misspell etc.

@stratoula
Copy link
Contributor Author

/ci

@stratoula stratoula marked this pull request as ready for review April 22, 2024 14:32
@stratoula stratoula requested a review from a team as a code owner April 22, 2024 14:32
@stratoula stratoula added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.14.0 v8.15.0 Team:Obs AI Assistant Observability AI Assistant labels Apr 22, 2024
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit 0643f63 into elastic:main Apr 22, 2024
31 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 22, 2024
)

## Summary

Relaxes the validation which means that we can't quick fix the quotes
problem but we are still fixing other syntax errors such as functions
misspell etc.

(cherry picked from commit 0643f63)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 22, 2024
) (#181343)

# Backport

This will backport the following commits from `main` to `8.14`:
- [[Obs AI assistant] Relax validation on missing fallbacks
(#181324)](#181324)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-04-22T16:09:09Z","message":"[Obs
AI assistant] Relax validation on missing fallbacks (#181324)\n\n##
Summary\r\n\r\nRelaxes the validation which means that we can't quick
fix the quotes\r\nproblem but we are still fixing other syntax errors
such as functions\r\nmisspell
etc.","sha":"0643f63d77aa0fd43c8bc380f72f4d9e53874768","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","Team:Obs
AI Assistant","v8.14.0","v8.15.0"],"title":"[Obs AI assistant] Relax
validation on missing
fallbacks","number":181324,"url":"https://github.com/elastic/kibana/pull/181324","mergeCommit":{"message":"[Obs
AI assistant] Relax validation on missing fallbacks (#181324)\n\n##
Summary\r\n\r\nRelaxes the validation which means that we can't quick
fix the quotes\r\nproblem but we are still fixing other syntax errors
such as functions\r\nmisspell
etc.","sha":"0643f63d77aa0fd43c8bc380f72f4d9e53874768"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/181324","number":181324,"mergeCommit":{"message":"[Obs
AI assistant] Relax validation on missing fallbacks (#181324)\n\n##
Summary\r\n\r\nRelaxes the validation which means that we can't quick
fix the quotes\r\nproblem but we are still fixing other syntax errors
such as functions\r\nmisspell
etc.","sha":"0643f63d77aa0fd43c8bc380f72f4d9e53874768"}}]}] BACKPORT-->

Co-authored-by: Stratoula Kalafateli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Obs AI Assistant Observability AI Assistant v8.14.0 v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants