[ML] AIOps: Fixes query string for the change point detection metric charts #181314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darnautov
added
release_note:fix
:ml
Team:ML
|
Pinging @elastic/ml-ui (:ml) |
| @@ -241,11 +241,14 @@ export const ChangePointDetectionContextProvider: FC = ({ children }) => { | |||
| if (requestParamsFromUrl.filters) { | |||
| filterManager.setFilters(requestParamsFromUrl.filters); | |||
| } | |||
| if (requestParamsFromUrl.query) { | |||
There was a problem hiding this comment.
Is this query getting cleared correctly when the data view is changed. Here I used farequote with a query of responsetime > 150, ran the analysis. Then I changed the data view to cloudwatch (split by instance):
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @darnautov |
peteharverson
approved these changes
Apr 23, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 24, 2024
## Summary Fixes elastic#179814 Query string from the Unified Search query bar was applying to the change point agg request, but wasn't in sync with the query service to correctly render the chart preview. With the PR the query string is synchronized and metric charts are rendered correctly. ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 2bd49f5)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
peteharverson
changed the title
kibanamachine
added a commit
that referenced
this pull request
Apr 24, 2024
…181549) # Backport This will backport the following commits from `main` to `8.14`: - [[ML] AIOps: Fix query string for the metric chart (#181314)](#181314) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dima Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-04-24T11:55:03Z","message":"[ML] AIOps: Fix query string for the metric chart (#181314)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/179814\r\n\r\nQuery string from the Unified Search query bar was applying to the\r\nchange point agg request, but wasn't in sync with the query service to\r\ncorrectly render the chart preview. With the PR the query string is\r\nsynchronized and metric charts are rendered correctly.\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"2bd49f5ae4816c75a87a371e58ca2b7ea73d4bd4","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Team:ML","Feature:ML/AIOps","v8.14.0","v8.15.0"],"title":"[ML] AIOps: Fix query string for the metric chart ","number":181314,"url":"https://github.com/elastic/kibana/pull/181314","mergeCommit":{"message":"[ML] AIOps: Fix query string for the metric chart (#181314)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/179814\r\n\r\nQuery string from the Unified Search query bar was applying to the\r\nchange point agg request, but wasn't in sync with the query service to\r\ncorrectly render the chart preview. With the PR the query string is\r\nsynchronized and metric charts are rendered correctly.\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"2bd49f5ae4816c75a87a371e58ca2b7ea73d4bd4"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/181314","number":181314,"mergeCommit":{"message":"[ML] AIOps: Fix query string for the metric chart (#181314)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/179814\r\n\r\nQuery string from the Unified Search query bar was applying to the\r\nchange point agg request, but wasn't in sync with the query service to\r\ncorrectly render the chart preview. With the PR the query string is\r\nsynchronized and metric charts are rendered correctly.\r\n\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"2bd49f5ae4816c75a87a371e58ca2b7ea73d4bd4"}}]}] BACKPORT--> Co-authored-by: Dima Arnautov <[email protected]>
kpatticha
pushed a commit
to kpatticha/kibana
that referenced
this pull request
Apr 26, 2024
## Summary Fixes elastic#179814 Query string from the Unified Search query bar was applying to the change point agg request, but wasn't in sync with the query service to correctly render the chart preview. With the PR the query string is synchronized and metric charts are rendered correctly. ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #179814
Query string from the Unified Search query bar was applying to the change point agg request, but wasn't in sync with the query service to correctly render the chart preview. With the PR the query string is synchronized and metric charts are rendered correctly.
Checklist