Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Network flows query "size": 0 #181310

Merged
merged 5 commits into from
Apr 24, 2024
Merged

[Security Solution] Network flows query "size": 0 #181310

merged 5 commits into from
Apr 24, 2024

Conversation

semd
Copy link
Contributor

@semd semd commented Apr 22, 2024 •
edited
Loading

Summary

Move the "size": 0 prop to the body in the network flow aggregation queries

@semd semd self-assigned this Apr 22, 2024
@semd semd added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Explore v8.15.0 labels Apr 22, 2024
@semd
Copy link
Contributor Author

semd commented Apr 22, 2024

/ci

@semd semd added the enhancement New value added to drive a business result label Apr 22, 2024
@semd
Copy link
Contributor Author

semd commented Apr 23, 2024

@elasticmachine merge upstream

@semd semd marked this pull request as ready for review April 23, 2024 14:18
@semd semd requested a review from a team as a code owner April 23, 2024 14:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

@semd semd force-pushed the 178372_explore_aggs_performance branch from 3c6a915 to 025194d Compare April 23, 2024 15:17
angorayc
angorayc approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@angorayc angorayc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up @semd

@semd semd enabled auto-merge (squash) April 24, 2024 09:25
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #8 / security APIs - Session Concurrent Limit Session Concurrent Limit cleanup should properly clean up sessions that exceeded concurrent session limit even for multiple providers

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @semd

@semd semd merged commit 53fa8bc into elastic:main Apr 24, 2024
36 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 24, 2024
kpatticha pushed a commit to kpatticha/kibana that referenced this pull request Apr 26, 2024
@semd @kpatticha
[Security Solution] Network flows query "size": 0 (elastic#181310)
ad52046 
## Summary

Move the `"size": 0` prop to the body in the network flow aggregation
queries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angorayc angorayc angorayc approved these changes

Assignees

@semd semd

Labels
backport:skip This commit does not require backporting enhancement New value added to drive a business result release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Explore v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@semd @elasticmachine @kibana-ci @angorayc @kibanamachine