[SecuritySolution] Add "exist filter" when value count is filtered in Lens cell action #181151

angorayc · 2024-04-18T13:19:39Z

Summary

Original issue and steps to reproduce: #181120

Before:

Screen.Recording.2024-04-17.at.2.13.45.PM.mov

After:

Screen.Recording.2024-04-18.at.14.15.34.mov

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios

PhilippeOberti

@angorayc thanks for fixing this and adding all the unit tests!

I was more expecting the hover actions to just not be displayed at all. Approving because this approach works as well!

angorayc · 2024-04-22T09:28:58Z

@angorayc thanks for fixing this and adding all the unit tests!

I was more expecting the hover actions to just not be displayed at all. Approving because this approach works as well!

@PhilippeOberti You are right, I checked the existing behaviour when filter on a count value in Lens, turned out it shouldn't have cell actions. Let me rework on this.

Screen.Recording.2024-04-22.at.10.11.40.mov

angorayc · 2024-04-23T09:43:25Z

When I was checking what's the correct behaviour, I found two different behaviours in Lens while filtering on a count value: Sometimes it has cell actions, sometime it doesn't.

Screen.Recording.2024-04-22.at.10.54.41.mov

Screen.Recording.2024-04-22.at.10.55.44.mov

After checking with the Kibana-visualization team, they confirmed that it's a bug. The count value should still have cell actions, so I think we are fine to add the exists filter when filtering on count value as the implementation in this PR.

However, it does not show cell actions when empty value in the Lens table, which is different from our existing logic at the moment, I think this is a behaviour we could consider aligning. I'm going to create another issue for this.

Security Solution still have cell actions available when value is empty:

Screen.Recording.2024-04-23.at.10.37.53.mov

Lens table does not have cell actions available when value is empty:

#181344

x-pack/plugins/security_solution/public/actions/filter/lens/create_action.ts

packages/kbn-cell-actions/src/actions/filter/filter_in.ts

…181120

semd · 2024-04-24T07:46:10Z

packages/kbn-cell-actions/src/actions/filter/filter_out.ts

+import { isEmptyFilterValue } from './create_filter';
+import { addFilter } from './add_filter';


NIT: It probably makes more sense now to move the isEmptyFilterValue function to the new add_filter.ts module as well. So actions will only have to import from add_filter module, and the create_filter module will become an internal module to help create the filters of add_filter module.

x-pack/plugins/security_solution/public/actions/filter/lens/create_action.ts

semd

Tested locally, everything is working as expected. Thanks @angorayc
LGTM!

…eate_action.ts Co-authored-by: Sergi Massaneda <[email protected]>

…181120

kibana-ci · 2024-04-24T09:41:21Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 1c648cf

Failed CI Steps

FTR Configs #37

Test Failures

[job] [logs] FTR Configs #37 / discover/ccs_compatible discover search CCS timeout bfetch enabled timeout on single shard shows warning and results with bfetch enabled

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`cloudSecurityPosture`	433	434	+1
`discover`	790	791	+1
`lens`	1403	1404	+1
`logsExplorer`	728	729	+1
`securitySolution`	5452	5453	+1
`slo`	724	725	+1
total			+6

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/cell-actions`	44	46	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`cloudSecurityPosture`	451.2KB	451.3KB	+94.0B
`discover`	638.2KB	638.3KB	+92.0B
`securitySolution`	14.6MB	14.7MB	+1.1KB
`slo`	722.8KB	722.9KB	+94.0B
total			+1.4KB

Unknown metric groups

API count

id	before	after	diff
`@kbn/cell-actions`	62	64	+2

History

💔 Build #205510 failed 2dc6033
💚 Build #205232 succeeded 4aea705
💔 Build #204807 failed d136fc5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @angorayc

… Lens cell action (elastic#181151) ## Summary Original issue and steps to reproduce: elastic#181120 Before: https://github.com/elastic/kibana/assets/6295984/10c7a2ce-d814-4750-8481-8f05b55384f8 After: https://github.com/elastic/kibana/assets/6295984/00dfbcb6-244b-4f2b-8dd4-a1f7435385cf ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Sergi Massaneda <[email protected]> (cherry picked from commit 42e6f0c)

kibanamachine · 2024-04-24T09:46:06Z

💚 All backports created successfully

Status	Branch	Result
✅	8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…nt is filtered in Lens cell action (#181151) (#181534) # Backport This will backport the following commits from `main` to `8.14`: - [[SecuritySolution] Add "exist filter" when value count is filtered in Lens cell action (#181151)](#181151)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Angela Chuang <[email protected]>

add exist filter when value count is filtered

fcb0106

angorayc added bug Fixes for quality problems that affect the customer experience v8.14.0 labels Apr 18, 2024

unit tests

cb59187

angorayc marked this pull request as ready for review April 18, 2024 17:41

angorayc requested review from a team as code owners April 18, 2024 17:41

PhilippeOberti approved these changes Apr 18, 2024

View reviewed changes

Merge branch 'main' into issue-181120

d136fc5

angorayc closed this Apr 22, 2024

angorayc mentioned this pull request Apr 23, 2024

[SecuritySolution] Cell actions should not appear when cell value is empty #181405

Open

typo

f304d81

angorayc reopened this Apr 23, 2024

Merge branch 'main' into issue-181120

4aea705

angorayc added the release_note:skip Skip the PR/issue when compiling release notes label Apr 23, 2024

angorayc changed the title ~~[SecuritySolution] Add exist filter when value count is filtered~~ [SecuritySolution] Add "exist filter" when value count is filtered in Lens cell action Apr 23, 2024

semd reviewed Apr 23, 2024

View reviewed changes

x-pack/plugins/security_solution/public/actions/filter/lens/create_action.ts Outdated Show resolved Hide resolved

semd reviewed Apr 23, 2024

View reviewed changes

x-pack/plugins/security_solution/public/actions/filter/lens/create_action.ts Outdated Show resolved Hide resolved

semd reviewed Apr 23, 2024

View reviewed changes

packages/kbn-cell-actions/src/actions/filter/filter_in.ts Outdated Show resolved Hide resolved

angorayc added 2 commits April 24, 2024 08:30

export addExistsFilter

c3108c6

Merge branch 'issue-181120' of github.com:angorayc/kibana into issue-…

9372751

…181120

semd reviewed Apr 24, 2024

View reviewed changes

x-pack/plugins/security_solution/public/actions/filter/lens/create_action.ts Outdated Show resolved Hide resolved

semd approved these changes Apr 24, 2024

View reviewed changes

semd assigned angorayc Apr 24, 2024

angorayc and others added 3 commits April 24, 2024 09:00

Update x-pack/plugins/security_solution/public/actions/filter/lens/cr…

2dc6033

…eate_action.ts Co-authored-by: Sergi Massaneda <[email protected]>

move isEmptyFilterValue to addFilter

52228b5

Merge branch 'issue-181120' of github.com:angorayc/kibana into issue-…

7fee237

…181120

clean up

1c648cf

angorayc enabled auto-merge (squash) April 24, 2024 08:12

angorayc merged commit 42e6f0c into elastic:main Apr 24, 2024
35 checks passed

kibanamachine added the v8.15.0 label Apr 24, 2024

kibanamachine mentioned this pull request Apr 24, 2024

[8.14] [SecuritySolution] Add "exist filter" when value count is filtered in Lens cell action (#181151) #181534

Merged

szaffarano mentioned this pull request Jul 12, 2024

[8.14] [Telemetry][Security Solution] Use the proper index to query builtin alerts (#187859) #188233

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SecuritySolution] Add "exist filter" when value count is filtered in Lens cell action #181151

[SecuritySolution] Add "exist filter" when value count is filtered in Lens cell action #181151

angorayc commented Apr 18, 2024 •

edited by kibanamachine

Loading

PhilippeOberti left a comment

angorayc commented Apr 22, 2024 •

edited

Loading

angorayc commented Apr 23, 2024 •

edited

Loading

semd Apr 24, 2024

semd left a comment

kibana-ci commented Apr 24, 2024

API count

kibanamachine commented Apr 24, 2024

		import { isEmptyFilterValue } from './create_filter';
		import { addFilter } from './add_filter';

[SecuritySolution] Add "exist filter" when value count is filtered in Lens cell action #181151

[SecuritySolution] Add "exist filter" when value count is filtered in Lens cell action #181151

Conversation

angorayc commented Apr 18, 2024 • edited by kibanamachine Loading

Summary

Checklist

PhilippeOberti left a comment

Choose a reason for hiding this comment

angorayc commented Apr 22, 2024 • edited Loading

angorayc commented Apr 23, 2024 • edited Loading

semd Apr 24, 2024

Choose a reason for hiding this comment

semd left a comment

Choose a reason for hiding this comment

kibana-ci commented Apr 24, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

API count

History

kibanamachine commented Apr 24, 2024

💚 All backports created successfully

Questions ?

angorayc commented Apr 18, 2024 •

edited by kibanamachine

Loading

angorayc commented Apr 22, 2024 •

edited

Loading

angorayc commented Apr 23, 2024 •

edited

Loading