Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] AIOps: Adds cardinality check to Log Rate Analysis #181129

Merged
merged 4 commits into from
May 21, 2024

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Apr 18, 2024

Summary

Part of #181111.

This filters field/value items from the results if the field has a cardinality of just 1 since it wouldn't be useful as a result.

Before (you can easily spot fields with cardinality of 1 because the mini histogram in the table is just one color which means the value is present in all logs):

image

After:

image

Checklist

@walterra walterra self-assigned this Apr 18, 2024
@walterra walterra force-pushed the ml-aiops-cardinality-check branch from f5fa13d to 8d1730a Compare May 16, 2024 12:50
@walterra walterra added release_note:enhancement :ml Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis v8.15.0 labels May 16, 2024
@walterra walterra marked this pull request as ready for review May 16, 2024 12:58
@walterra walterra requested a review from a team as a code owner May 16, 2024 12:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - confirmed with the pgbench data set with container.id query that items with a cardinality of 1 are no longer shown.

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@walterra walterra merged commit d43c8f9 into elastic:main May 21, 2024
17 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 21, 2024
@walterra walterra deleted the ml-aiops-cardinality-check branch May 21, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis :ml release_note:enhancement v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants