Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Single Metric Viewer embeddable: show error message when insufficient permissions #180858

Conversation

alvarezmelissa87
Copy link
Contributor

Summary

When the user does not have enough permissions, ensures that the single metric viewer panel in dashboards shows an error message (similar to the other ML dashboard panels) instead of just being blank.

Before:

Screenshot 2024-04-15 at 09 45 44

After:

image

Checklist

Delete any items that are not applicable to this PR.

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@alvarezmelissa87 alvarezmelissa87 added the Feature:Anomaly Detection ML anomaly detection label Apr 15, 2024
@qn895
Copy link
Member

qn895 commented Apr 15, 2024

Code LGTM 🎉

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, and other than the suggested edit for the error text on the three ML embeddable panels, LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 4.1MB 4.1MB +449.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alvarezmelissa87

@alvarezmelissa87 alvarezmelissa87 merged commit fa90d2f into elastic:main Apr 16, 2024
16 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 16, 2024
@alvarezmelissa87 alvarezmelissa87 deleted the ml-smv-embeddable-permission-fix branch April 16, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Anomaly Detection ML anomaly detection :ml release_note:fix v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants