-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Single Metric Viewer embeddable: show error message when insufficient permissions #180858
[ML] Single Metric Viewer embeddable: show error message when insufficient permissions #180858
Conversation
Pinging @elastic/ml-ui (:ml) |
Code LGTM 🎉 |
...ins/ml/public/embeddables/single_metric_viewer/embeddable_single_metric_viewer_container.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, and other than the suggested edit for the error text on the three ML embeddable panels, LGTM
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Summary
When the user does not have enough permissions, ensures that the single metric viewer panel in dashboards shows an error message (similar to the other ML dashboard panels) instead of just being blank.
Before:
After:
Checklist
Delete any items that are not applicable to this PR.