Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Get Started][KEYBOARD]: Elements in closed accordions must not be able to take keyboard focus #180678

Merged
merged 11 commits into from
Apr 29, 2024

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Apr 12, 2024

Closes: https://github.com/elastic/security-team/issues/8898

Description

The Security > Get Started view for Serverless projects has a number of accordions that do not remove focusable content from the DOM. This can lead to a situation where keyboard users' focus is lost inside a closed accordion. This can create bad UX as the number of focusable elements inside an accordion increase. Screenshot attached below.

Steps to recreate

  1. Open Cloud UI and create a Serverless Security project if none exist
  2. When the project is created, click the Continue button
  3. Navigate to the Security project Get started view. This link is in the lower left of the navigation pane.
  4. Tab through the page until you see focus on the downward arrow on an accordion. Tab again and notice the focus disappears.
  5. Verify focus is on a hidden element by opening the Console and typing document.activeElement into the prompt. This will show focus is on an element inside the accordion.

What was done?:

  1. visible style was added. Using a visibility value of hidden/collapse on an element will remove it from the accessibility tree.

Screen:

Screen.Recording.2024-04-12.at.13.13.32.mov

@alexwizp
Copy link
Contributor Author

/ci

@alexwizp alexwizp added v8.14.0 Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. release_note:skip Skip the PR/issue when compiling release notes Feature:SecurityOverview Security Solution Overview feature Team:Threat Hunting Security Solution Threat Hunting Team and removed Feature:SecurityOverview Security Solution Overview feature labels Apr 12, 2024
@alexwizp alexwizp marked this pull request as ready for review April 12, 2024 10:14
@alexwizp alexwizp requested a review from a team as a code owner April 12, 2024 10:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@alexwizp alexwizp requested review from lgestc and rylnd April 26, 2024 15:32
@alexwizp alexwizp added v8.15.0 and removed v8.14.0 labels Apr 26, 2024
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #40 / alerting api integration security and spaces enabled Alerts - Group 1 alerts backfill rule runs ad hoc backfill task should handle timeouts

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 13.7MB 13.7MB +185.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexwizp alexwizp merged commit b25afaa into elastic:main Apr 29, 2024
35 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants