[Security Solution] fix issue related to local storage on expandable flyout non-alert document #180391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeOberti
added
release_note:skip
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
PhilippeOberti
commented
Apr 9, 2024
| @@ -58,7 +58,17 @@ export const RightPanel: FC<Partial<RightPanelProps>> = memo(({ path }) => { | |||
| const defaultTab = tabsDisplayed[0].id; | |||
| const tabSavedInlocalStorage = storage.get(FLYOUT_STORAGE_KEYS.RIGHT_PANEL_SELECTED_TABS); | |||
|
|
|||
| if (!path) return tabSavedInlocalStorage || defaultTab; | |||
| if (!path) { | |||
There was a problem hiding this comment.
I'm considering wrapping this whole useMemo (and the previous one calculating the tabDisplayed) into a hook to make this unit testable.
What do you think @christineweng
There was a problem hiding this comment.
@christineweng I implemented the hook and its unit test in this last commit
…flyout non-alert document
PhilippeOberti
force-pushed
the
fix-local-storage-default-path
branch
from
92edb72 to
e9d7f1b
Compare
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
christineweng
approved these changes
Apr 10, 2024
kibanamachine
added
v8.14.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a small issue introduced in this previous PR, where if the user clicks on the
Overviewtab, that selection is saved in local storage. When the user opens a non-alert document that does not have theOverviewtab (see details in this PR), the view does not default back to theTabletab.Previous (broken) behavior:
Screen.Recording.2024-04-09.at.10.21.40.AM.mov
Fixed behavior:
Screen.Recording.2024-04-09.at.10.17.32.AM.mov
Checklist