-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Transforms: Use estypes.TransformGetTransformStatsTransformStats
for transform stats.
#180347
Conversation
Pinging @elastic/ml-ui (:ml) |
estypes.TransformGetTransformStatsTransformStatsHealth
for transform stats.estypes.TransformGetTransformStatsTransformStats
for transform stats.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
use constant instead of raw string for `unknown`. Co-authored-by: Dima Arnautov <[email protected]>
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @walterra |
Code LGTM 🎉 |
Summary
Gets rid of a lot of the manually defined attributes of
TransformStats
by extending fromestypes.TransformGetTransformStatsTransformStats
.How we treat the transform health status needed to be adapted because the types provided by
estypes
are both lower and upper case (e.g.green/GREEN
) but lack theunknown
status we use in the UI.mapEsHealthStatus2TransformHealthStatus()
is used to transform a health status returned via API to the one we use in the UI.Checklist