Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Transforms: Use estypes.TransformGetTransformStatsTransformStats for transform stats. #180347

Merged
merged 10 commits into from
Apr 10, 2024

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Apr 9, 2024

Summary

Gets rid of a lot of the manually defined attributes of TransformStats by extending from estypes.TransformGetTransformStatsTransformStats.

How we treat the transform health status needed to be adapted because the types provided by estypes are both lower and upper case (e.g. green/GREEN) but lack the unknown status we use in the UI. mapEsHealthStatus2TransformHealthStatus() is used to transform a health status returned via API to the one we use in the UI.

Checklist

@walterra walterra added :ml release_note:skip Skip the PR/issue when compiling release notes Feature:Transforms ML transforms v8.14.0 labels Apr 9, 2024
@walterra walterra self-assigned this Apr 9, 2024
@walterra walterra requested a review from a team as a code owner April 9, 2024 09:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@walterra walterra requested review from darnautov and qn895 April 9, 2024 09:17
@walterra walterra changed the title [ML] Transforms: Use estypes.TransformGetTransformStatsTransformStatsHealth for transform stats. [ML] Transforms: Use estypes.TransformGetTransformStatsTransformStats for transform stats. Apr 9, 2024
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

x-pack/plugins/transform/common/constants.ts Outdated Show resolved Hide resolved
use constant instead of raw string for `unknown`.

Co-authored-by: Dima Arnautov <[email protected]>
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
transform 391.9KB 392.1KB +192.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
transform 18.5KB 18.7KB +163.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@qn895
Copy link
Member

qn895 commented Apr 10, 2024

Code LGTM 🎉

@walterra walterra merged commit 756a41b into elastic:main Apr 10, 2024
16 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Transforms ML transforms :ml release_note:skip Skip the PR/issue when compiling release notes v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants