-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Console Monaco] Add theme for yaml and text mode in output #180080
[Console Monaco] Add theme for yaml and text mode in output #180080
Conversation
/ci |
Pinging @elastic/kibana-management (Team:Kibana Management) |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @ElenaStoeva |
Converting to draft as we might need to defer merging this until we resolve #180218 since this issue is related to assigning different themes in the output panel. |
Closing as we will use a single theme for both the editor and the output panel (see #180321). |
Addresses #179905
Summary
This PR adds themes for the Console output panel when it is in YAML or Text mode. The main theme features that are specified for these two main modes are colors (e.g. background color).
How to test:
config/kibana.dev.yml
file (if one doesn't exist already) and add the line:console.dev.enableMonaco: true
kibana/src/plugins/console/public/application/containers/editor/editor.tsx
Line 76 in b8c13ba
!isMonacoEnabled
to display the old Ace editor in the request panel for now so that we can test sending a request.?format=yaml
parameter (e.g.GET _all?format=yaml
) and verify that the theme (apart from the text colors) is the same as in json.src/plugins/console/public/application/containers/editor/monaco/monaco_editor_output.tsx
:Then reload the Console page and verify that the theme (apart from the text colors) is the same as in json: