Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EUI to v93.5.1 #179363

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Upgrade EUI to v93.5.1 #179363

merged 4 commits into from
Mar 26, 2024

Conversation

cee-chen
Copy link
Contributor

@cee-chen cee-chen commented Mar 25, 2024

v93.4.0v93.5.1


v93.5.1

Bug fixes

  • Fixed unvirtualized EuiSelectables to not cause Jest/jsdom errors on active option change (#7618)

v93.5.0

  • EuiHeaderLinks now accepts a children render function that will be passed a closeMobilePopover callback, allowing consumers to close the mobile popover by its content (#7603)
  • Updated EuiSelectable to support scrolling list containers when listProps.isVirtualization is set to false (#7609)

Bug fixes

  • Fixed EuiIconTip's default aria-label text to be i18n tokenizable (#7606)
  • Fixed EuiTextArea's CSS box model to no longer render a few extra pixels of strut height (#7607)

Dependency updates

  • Updated @types/refractor to v3.4.0 (#7590)
  • Updated @types/lodash to v4.14.202 (#7591)
  • Removed @types/resize-observer-browser dependency. ResizeObserver types should already be baked in to Typescript as of 4.2+ (#7592)
  • Updated classnames to v2.5.1 (#7593)
  • Updated @types/numeral to v2.0.5 (#7594)
  • Updated @types/react-window to 1.8.8 (#7597)
  • Updated prop-types to v15.18.1 (#7602)
  • Removed prop-types as a peer dependency, per package recommendation (#7602)

Accessibility

  • EuiIcons no longer apply aria-hidden to empty icons, as long as a valid title or label is provided to the icon. In particular, this is intended to improve the accessibility of loading EuiIconTips. (#7606)

@cee-chen cee-chen added release_note:skip Skip the PR/issue when compiling release notes EUI v8.14.0 labels Mar 25, 2024
@cee-chen
Copy link
Contributor Author

/ci

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] x-pack/test/cloud_security_posture_functional/config.ts / Cloud Security Posture Cloud Posture Rules Page "before each" hook for "Shows posture score when there are findings"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.2MB 3.2MB +1.0B
infra 1.4MB 1.4MB +2.8KB
kubernetesSecurity 211.0KB 213.9KB +2.8KB
maps 2.9MB 2.9MB +2.8KB
ml 3.7MB 3.7MB +1.0B
visTypeVega 1.8MB 1.8MB +2.8KB
total +11.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 405.1KB 405.2KB +107.0B
kbnUiSharedDeps-css 273.7KB 273.7KB +46.0B
kbnUiSharedDeps-npmDll 6.3MB 6.3MB +9.0B
total +162.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cee-chen cee-chen marked this pull request as ready for review March 25, 2024 21:51
@cee-chen cee-chen requested review from a team as code owners March 25, 2024 21:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

@cee-chen cee-chen changed the title Upgrade EUI to v93.5.0 Upgrade EUI to v93.5.1 Mar 25, 2024
@kc13greiner kc13greiner self-requested a review March 26, 2024 11:56
Copy link
Contributor

@kc13greiner kc13greiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cee-chen cee-chen merged commit 8eb2fbd into elastic:main Mar 26, 2024
35 checks passed
@cee-chen cee-chen deleted the eui/v93.5.0 branch March 26, 2024 15:44
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants