Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security] Split quality gate security solution pipelines to add more granularity. #179145

Merged
merged 31 commits into from
Mar 27, 2024
Merged

[Security] Split quality gate security solution pipelines to add more granularity. #179145

merged 31 commits into from
Mar 27, 2024

Conversation

dkirchan
Copy link
Contributor

@dkirchan dkirchan commented Mar 21, 2024 •
edited
Loading

This PR aims to deprecate the old all in one pipeline for kibana serverless security solution cypress and split it into one pipeline per team to add more granularity.

We need to split the pipelines and then add as well one Test suite per team.

All this PR does is the split into multiple pipelines, one per team, with their relevant test suite in buildkite:

Relevant Tickets:

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@dkirchan dkirchan self-assigned this Mar 21, 2024
@dkirchan dkirchan added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Mar 21, 2024
@dkirchan @delanni
Update .buildkite/pipeline-resource-definitions/kibana-serverless-sec…
bc2fa63 
…urity-solution-quality-gate-explore.yml

Co-authored-by: Alex Szabo <[email protected]>
@dkirchan dkirchan marked this pull request as ready for review March 26, 2024 14:11
@dkirchan dkirchan requested a review from a team as a code owner March 26, 2024 14:11
@dkirchan dkirchan requested a review from a team March 26, 2024 14:20
delanni
delanni approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@delanni delanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

delanni
delanni reviewed Mar 27, 2024
View reviewed changes
x-pack/plugins/security_solution/scripts/run_cypress/parallel_serverless.ts Outdated
@@ -140,7 +140,13 @@ async function createSecurityProject(
};
} catch (error) {
if (error instanceof AxiosError) {
log.error(`${error.response?.status}:${error.response?.data}`);
<<<<<<< Updated upstream
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

watch out, merge conflict

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

MadameSheema
MadameSheema requested changes Mar 27, 2024
View reviewed changes
Copy link
Member

@MadameSheema MadameSheema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the log line again, thanks! :)

MadameSheema
MadameSheema approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@MadameSheema MadameSheema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dkirchan

@dkirchan dkirchan merged commit b81d5a9 into main Mar 27, 2024
34 checks passed
@dkirchan dkirchan deleted the split-quality-gate-pipeline-init branch March 27, 2024 17:21
@mgiota mgiota mentioned this pull request May 27, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delanni delanni delanni approved these changes

@MadameSheema MadameSheema MadameSheema approved these changes

@patrykkopycinski patrykkopycinski Awaiting requested review from patrykkopycinski

@oatkiller oatkiller Awaiting requested review from oatkiller

@maximpn maximpn Awaiting requested review from maximpn

@banderror banderror Awaiting requested review from banderror

Assignees

@dkirchan dkirchan

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dkirchan @apmmachine @kibana-ci @delanni @MadameSheema @kibanamachine