fixing goal max and goal value configuration #179133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppisljar
added
Team:Visualizations
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
dej611
reviewed
Mar 21, 2024
There was a problem hiding this comment.
Not really sure to get the changes here.
Are changes meant to fix some broken tests or rather test something else more in depth?
If the former, then it would be nice to know what was wrong.
Otherwise can we keep the previous tests and add the new ones?
ppisljar
force-pushed
the
lensconfig/fix2
branch
from
59a6157 to
1403069
Compare
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixing goal max and goal value configuration
max and goal value used wrong accessor names,
adding both to the test, so we dont break this in the future
Checklist