Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Allowing to use ftr archives in Cypress #178724

Merged
merged 14 commits into from
Mar 15, 2024

Conversation

MadameSheema
Copy link
Member

@MadameSheema MadameSheema commented Mar 14, 2024

Summary

Per @rylnd requirement, we are extending our es_archiver cypress task in order to be capable to use archives placed in x-pack/test/functional/es_archives/security_solution in Cypress.

Archives living in our Cypress directory

Use the following commands to load and unload the archive in your test.

    cy.task('esArchiverLoad', { archiveName: 'timeline' });
    cy.task('esArchiverUnload', { archiveName: 'timeline' });

Archives living in x-pack/test/functional/es_archives/security_solution

Use the following commands to load and unload the archive in your test.

    cy.task('esArchiverLoad', { archiveName: 'alias', type: 'ftr' });
    cy.task('esArchiverUnload', { archiveName: 'alias', type: 'ftr' });

In this PR we are also adding the /^x-pack/test/functional/es_archives/security_solution route as a dependency when executing tests in buildkite to make sure that changes there are not breaking the Security Solution Cypress tests.

@MadameSheema
Copy link
Member Author

/ci

@MadameSheema
Copy link
Member Author

/ci

@MadameSheema MadameSheema changed the title allowing to load ftr archives [Security Solution] Allowing to use ftr archives in Cypress Mar 14, 2024
@MadameSheema
Copy link
Member Author

/ci

@MadameSheema MadameSheema added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.14.0 labels Mar 14, 2024
@MadameSheema MadameSheema marked this pull request as ready for review March 14, 2024 15:32
@MadameSheema MadameSheema requested review from a team as code owners March 14, 2024 15:32
@MadameSheema MadameSheema requested a review from hop-dev March 14, 2024 15:32
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@MadameSheema MadameSheema requested a review from dhurley14 March 14, 2024 15:32
Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wonderful! I was hoping it was a quick feature, but this was impressively fast. Thank you!

@MadameSheema MadameSheema enabled auto-merge (squash) March 14, 2024 17:34
Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks Glo

@MadameSheema MadameSheema disabled auto-merge March 14, 2024 19:12
@MadameSheema MadameSheema enabled auto-merge (squash) March 14, 2024 20:30
@yctercero yctercero removed the request for review from dhurley14 March 15, 2024 00:10
Copy link

@vgomez-el vgomez-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the Threat Hunting Investigations team!

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] x-pack/test/cloud_security_posture_functional/config.ts / Cloud Security Posture Findings Page - Alerts Create detection rule Creates a detection rule from the Alerts section and navigates to rule page
  • [job] [logs] Defend Workflows Cypress Tests on Serverless #1 / User Roles for Security Complete PLI with Endpoint Complete addon for role: soc_manager Response Actions access "before each" hook for "should have access to execute action: release" "before each" hook for "should have access to execute action: release"
  • [job] [logs] Defend Workflows Cypress Tests on Serverless #1 / User Roles for Security Complete PLI with Endpoint Complete addon for role: t3_analyst Response Actions access "before each" hook for "should have access to execute action: upload" "before each" hook for "should have access to execute action: upload"

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@MadameSheema MadameSheema merged commit f1e093e into elastic:main Mar 15, 2024
37 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Mar 15, 2024
rylnd added a commit to rylnd/kibana that referenced this pull request Mar 15, 2024
In elastic#178724, we added the ability to retrieve archives from another
location (namely, where our FTR archives live). This allows me to delete
the duplicated archive specific for the cypress usage, and share the FTR
archive between both. Nice!
@MadameSheema MadameSheema deleted the esarchiver-improvement branch June 28, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants