-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Allowing to use ftr archives in Cypress #178724
[Security Solution] Allowing to use ftr archives in Cypress #178724
Conversation
/ci |
/ci |
/ci |
Pinging @elastic/security-solution (Team: SecuritySolution) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wonderful! I was hoping it was a quick feature, but this was impressively fast. Thank you!
x-pack/test/security_solution_cypress/cypress/support/es_archiver.ts
Outdated
Show resolved
Hide resolved
x-pack/test/security_solution_cypress/cypress/support/es_archiver.ts
Outdated
Show resolved
Hide resolved
…ver.ts Co-authored-by: Ryland Herrick <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks Glo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the Threat Hunting Investigations team!
💛 Build succeeded, but was flaky
Failed CI Steps
Test Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
In elastic#178724, we added the ability to retrieve archives from another location (namely, where our FTR archives live). This allows me to delete the duplicated archive specific for the cypress usage, and share the FTR archive between both. Nice!
Summary
Per @rylnd requirement, we are extending our es_archiver cypress task in order to be capable to use archives placed in
x-pack/test/functional/es_archives/security_solution
in Cypress.Archives living in our Cypress directory
Use the following commands to load and unload the archive in your test.
Archives living in
x-pack/test/functional/es_archives/security_solution
Use the following commands to load and unload the archive in your test.
In this PR we are also adding the
/^x-pack/test/functional/es_archives/security_solution
route as a dependency when executing tests in buildkite to make sure that changes there are not breaking the Security Solution Cypress tests.