Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Removing job_type from test data AD job #178715

Merged
merged 2 commits into from
Mar 18, 2024
Merged

[ML] Removing job_type from test data AD job #178715

merged 2 commits into from
Mar 18, 2024

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Mar 14, 2024 •
edited
Loading

job_type should not be part of the job config when creating a job. This was accidentally left in for some test data.

Related to #178562 and elastic/elasticsearch#106277

@jgowdyelastic
Copy link
Member Author

/ci

@jan-elastic jan-elastic self-assigned this Mar 14, 2024
jan-elastic
jan-elastic approved these changes Mar 14, 2024
View reviewed changes
Copy link

@jan-elastic jan-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgowdyelastic jgowdyelastic marked this pull request as ready for review March 14, 2024 13:15
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner March 14, 2024 13:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@jgowdyelastic jgowdyelastic added release_note:skip Skip the PR/issue when compiling release notes v8.14.0 labels Mar 14, 2024
peteharverson
peteharverson approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jan-elastic jan-elastic mentioned this pull request Mar 15, 2024
Merged
@jan-elastic
Copy link

@jgowdyelastic Any chance you could merge this? It's blocking my PR. Thanks!

@jgowdyelastic jgowdyelastic enabled auto-merge (squash) March 18, 2024 19:19
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #1 / Actions and Triggers app Global alerts page Loads the page with actions but not alerting privilege Loads the page but shows missing permission prompt

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@jgowdyelastic jgowdyelastic merged commit 46edb39 into elastic:main Mar 18, 2024
18 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Mar 18, 2024
saikatsarkar056 pushed a commit to saikatsarkar056/kibana that referenced this pull request Mar 21, 2024
@jgowdyelastic @saikatsarkar056
[ML] Removing job_type from test data AD job (elastic#178715)
65f08d3 
`job_type` should not be part of the job config when creating a job.
This was accidentally left in for some test data.

Related to elastic#178562 and
elastic/elasticsearch#106277
@jgowdyelastic jgowdyelastic mentioned this pull request Mar 28, 2024
Merged
jgowdyelastic added a commit that referenced this pull request Mar 28, 2024
@jgowdyelastic
[ML] Fixing broken test due to job_type 7.17 (#179604)
297556f 
Removes `job_type` from test data, similar to
#178715

Fixes #179167
Fixes #179181
@qn895 qn895 mentioned this pull request Mar 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-elastic jan-elastic jan-elastic approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
backport:skip This commit does not require backporting Feature:Anomaly Detection ML anomaly detection :ml release_note:skip Skip the PR/issue when compiling release notes v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jgowdyelastic @elasticmachine @jan-elastic @kibana-ci @peteharverson @kibanamachine