fix: [Dashboard > Entity Analytics: Risk Scores Table][KEYBOARD]: Elements with keyboard focus must be visible #178317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ments with keyboard focus must be visible CLoses: elastic/security-team#8624
|
/ci |
alexwizp
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
alexwizp
added
v8.13.0
v8.14.0
release_note:skip
|
Pinging @elastic/security-entity-analytics (Team:Entity Analytics) |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 12, 2024
…ments with keyboard focus must be visible (elastic#178317) Closes: elastic/security-team#8624 ## Description The Overview dashboard has two buttons that are invisible on keyboard focus. These buttons toggle modal dialogs and are only visible on hover. Screenshot attached. ### Steps to recreate 1. Open [Entity Analytics dashboard](https://kibana.siem.estc.dev/app/security/entity_analytics) 2. Open dev tools and type `document.activeElement` into the live expression window to have the active element follow your focus 3. Tab through the view until focus gets "lost" or disappears in the User Risk Scores table rows 4. Verify focus is on a button that is not visible on the page ### Screen https://github.com/elastic/kibana/assets/20072247/0ca8db38-006a-49ea-9019-e23078844c10 (cherry picked from commit 322b9a4)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 12, 2024
…OARD]: Elements with keyboard focus must be visible (#178317) (#178479) # Backport This will backport the following commits from `main` to `8.13`: - [fix: [Dashboard > Entity Analytics: Risk Scores Table][KEYBOARD]: Elements with keyboard focus must be visible (#178317)](#178317) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-03-12T09:56:02Z","message":"fix: [Dashboard > Entity Analytics: Risk Scores Table][KEYBOARD]: Elements with keyboard focus must be visible (#178317)\n\nCloses: https://github.com/elastic/security-team/issues/8624\r\n\r\n## Description\r\n\r\nThe Overview dashboard has two buttons that are invisible on keyboard\r\nfocus. These buttons toggle modal dialogs and are only visible on hover.\r\nScreenshot attached.\r\n\r\n### Steps to recreate\r\n\r\n1. Open [Entity Analytics\r\ndashboard](https://kibana.siem.estc.dev/app/security/entity_analytics)\r\n2. Open dev tools and type `document.activeElement` into the live\r\nexpression window to have the active element follow your focus\r\n3. Tab through the view until focus gets \"lost\" or disappears in the\r\nUser Risk Scores table rows\r\n4. Verify focus is on a button that is not visible on the page\r\n\r\n### Screen \r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/20072247/0ca8db38-006a-49ea-9019-e23078844c10","sha":"322b9a4ecb55a5db3295a5f764c21c8d7b37d400","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team: SecuritySolution","Feature:Security Dashboards","Team:Entity Analytics","v8.13.0","v8.14.0"],"title":"fix: [Dashboard > Entity Analytics: Risk Scores Table][KEYBOARD]: Elements with keyboard focus must be visible","number":178317,"url":"https://github.com/elastic/kibana/pull/178317","mergeCommit":{"message":"fix: [Dashboard > Entity Analytics: Risk Scores Table][KEYBOARD]: Elements with keyboard focus must be visible (#178317)\n\nCloses: https://github.com/elastic/security-team/issues/8624\r\n\r\n## Description\r\n\r\nThe Overview dashboard has two buttons that are invisible on keyboard\r\nfocus. These buttons toggle modal dialogs and are only visible on hover.\r\nScreenshot attached.\r\n\r\n### Steps to recreate\r\n\r\n1. Open [Entity Analytics\r\ndashboard](https://kibana.siem.estc.dev/app/security/entity_analytics)\r\n2. Open dev tools and type `document.activeElement` into the live\r\nexpression window to have the active element follow your focus\r\n3. Tab through the view until focus gets \"lost\" or disappears in the\r\nUser Risk Scores table rows\r\n4. Verify focus is on a button that is not visible on the page\r\n\r\n### Screen \r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/20072247/0ca8db38-006a-49ea-9019-e23078844c10","sha":"322b9a4ecb55a5db3295a5f764c21c8d7b37d400"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/178317","number":178317,"mergeCommit":{"message":"fix: [Dashboard > Entity Analytics: Risk Scores Table][KEYBOARD]: Elements with keyboard focus must be visible (#178317)\n\nCloses: https://github.com/elastic/security-team/issues/8624\r\n\r\n## Description\r\n\r\nThe Overview dashboard has two buttons that are invisible on keyboard\r\nfocus. These buttons toggle modal dialogs and are only visible on hover.\r\nScreenshot attached.\r\n\r\n### Steps to recreate\r\n\r\n1. Open [Entity Analytics\r\ndashboard](https://kibana.siem.estc.dev/app/security/entity_analytics)\r\n2. Open dev tools and type `document.activeElement` into the live\r\nexpression window to have the active element follow your focus\r\n3. Tab through the view until focus gets \"lost\" or disappears in the\r\nUser Risk Scores table rows\r\n4. Verify focus is on a button that is not visible on the page\r\n\r\n### Screen \r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/20072247/0ca8db38-006a-49ea-9019-e23078844c10","sha":"322b9a4ecb55a5db3295a5f764c21c8d7b37d400"}}]}] BACKPORT--> Co-authored-by: Alexey Antonov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/elastic/security-team/issues/8624
Description
The Overview dashboard has two buttons that are invisible on keyboard focus. These buttons toggle modal dialogs and are only visible on hover. Screenshot attached.
Steps to recreate
document.activeElementinto the live expression window to have the active element follow your focusScreen
Screen.Recording.2024-03-08.at.15.52.27.mov