Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] use lexer from elasticsearch #178257

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

drewdaemon
Copy link
Contributor

@drewdaemon drewdaemon commented Mar 7, 2024

Summary

Part of #173817

Up till now, we had to define our own lexer rules for our client-side ES|QL validation. This was because we were using an unofficial ANTLR package (before the official ANTLR had typescript support).

Now that we are using the official ANTLR library (as of #177211), we no longer have to encode case insensitivity into the lexer rules themselves because the caseInsensitive option is now available to us.

This means we can adopt the very same definitions that Elasticsearch uses as long as we set caseInsensitive (Elasticsearch handles case insensitivity at runtime).

Checklist

@drewdaemon drewdaemon changed the title [ES|QL] use grammar from elasticsearch [ES|QL] use lexer from elasticsearch Mar 7, 2024
@drewdaemon
Copy link
Contributor Author

/ci

@drewdaemon drewdaemon added release_note:skip Skip the PR/issue when compiling release notes Feature:ES|QL ES|QL related features in Kibana labels Mar 7, 2024
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@drewdaemon drewdaemon marked this pull request as ready for review March 7, 2024 20:06
@drewdaemon drewdaemon requested a review from a team as a code owner March 7, 2024 20:06
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!! 🚀

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am super happy for this change! LGTM! Thanx Drew

@drewdaemon drewdaemon merged commit 05dfb28 into elastic:main Mar 8, 2024
21 checks passed
@kibanamachine kibanamachine added v8.14.0 backport:skip This commit does not require backporting labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants