Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] Update configuration updates immediately after configuration changed #178171

Merged

Conversation

efegurkan
Copy link
Member

@efegurkan efegurkan commented Mar 6, 2024

Summary

Screen.Recording.2024-03-07.at.00.48.28.mov

Checklist

Delete any items that are not applicable to this PR.

@efegurkan efegurkan added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.13.0 v8.14.0 labels Mar 6, 2024
@efegurkan efegurkan requested a review from a team March 6, 2024 23:49
Copy link
Member

@sphilipse sphilipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@efegurkan efegurkan enabled auto-merge (squash) March 12, 2024 10:26
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.7MB 2.7MB +114.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@efegurkan efegurkan merged commit e864880 into elastic:main Mar 12, 2024
17 checks passed
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.13 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 178171

Questions ?

Please refer to the Backport tool documentation

@efegurkan
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.13

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

efegurkan added a commit to efegurkan/kibana that referenced this pull request Mar 12, 2024
… changed (elastic#178171)

## Summary

https://github.com/elastic/kibana/assets/1410658/9646ef5a-0a50-481e-93ae-864cc404d5d7

### Checklist

Delete any items that are not applicable to this PR.

- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

(cherry picked from commit e864880)

# Conflicts:
#	x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/connector_detail/connector_view_logic.ts
sphilipse pushed a commit that referenced this pull request Mar 12, 2024
…uration changed (#178171) (#178489)

# Backport

This will backport the following commits from `main` to `8.13`:
- [[Search] Update configuration updates immediately after configuration
changed (#178171)](#178171)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Efe Gürkan
YALAMAN","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-03-12T10:29:59Z","message":"[Search]
Update configuration updates immediately after configuration changed
(#178171)\n\n##
Summary\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/1410658/9646ef5a-0a50-481e-93ae-864cc404d5d7\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests
changed","sha":"e864880173a9487c11bc97f20238435754bbdcb0","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:EnterpriseSearch","v8.13.0","v8.14.0"],"number":178171,"url":"https://github.com/elastic/kibana/pull/178171","mergeCommit":{"message":"[Search]
Update configuration updates immediately after configuration changed
(#178171)\n\n##
Summary\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/1410658/9646ef5a-0a50-481e-93ae-864cc404d5d7\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests
changed","sha":"e864880173a9487c11bc97f20238435754bbdcb0"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","labelRegex":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/178171","number":178171,"mergeCommit":{"message":"[Search]
Update configuration updates immediately after configuration changed
(#178171)\n\n##
Summary\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/1410658/9646ef5a-0a50-481e-93ae-864cc404d5d7\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [ ] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests
changed","sha":"e864880173a9487c11bc97f20238435754bbdcb0"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.13.0 v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants