Revert "Support PKCS#12 encoded certificates (#17261)" #17801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit de91bd0.
legrego
reviewed
Apr 19, 2018
src/server/config/schema.test.js
Outdated
| const { error } = validate(config); | ||
| expect(error).toBe(null); | ||
| expect(error).to.be.an(Object); |
There was a problem hiding this comment.
This revert might fail - I think this file was converted to use jest's expect outside of this PR, so calls like .to.be.an(...) may break.
💚 Build Succeeded |
jbudz
approved these changes
Apr 19, 2018
kobelb
added a commit
to kobelb/kibana
that referenced
this pull request
Apr 19, 2018
…c#17801) * Revert "Support PKCS#12 encoded certificates (elastic#17261)" This reverts commit de91bd0. * Fixing tests
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit de91bd0.
The PKCS#12 certificate includes the equivalent of the cert/key and cas in a single file, which made it rather difficult to only use the certificate authorities for connections that we proxy through the kibana server for end-user request (callWithRequest, elasticsearch plugin proxy)
We still want support for PKCS#12, but we need to think through how to reliably extract only the certification authorities when that's necessary.