[Fleet] Add fleet subfeatures

[nchaulet]

Summary

Resolve https://github.com/elastic/ingest-dev/issues/2892

Introduce this under a fleet feature flag subfeaturePrivileges, so this will have no impact for users.

The privileges UI is currently broken but will be fixed by #178239

@elastic/kibana-security it seems there is a bug nothing happened when I click on customize sub-features.
If I remove requireAllSpaces: true from the top privilieges it seems to work, but currently fleet require all spaces.

How to test

Add the following to your kibana.dev.yml

xpack.fleet.enableExperimental: ['subfeaturePrivileges']

[apmmachine]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
• /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[azasypkin]

@elastic/kibana-security it seems there is a bug nothing happened when I click on customize sub-features.
If I remove requireAllSpaces: true from the top privilieges it seems to work, but currently fleet require all spaces.

Yeah, looks like a bug indeed, I'll dig into this tomorrow.

[azasypkin]

Presumably something like this should fix the bug, but I'd like to take a closer look tomorrow before proposing/working-on the solution:

diff --git a/x-pack/plugins/security/public/management/roles/edit_role/privileges/kibana/feature_table/feature_table_expanded_row.tsx b/x-pack/plugins/security/public/management/roles/edit_role/privileges/kibana/feature_table/feature_table_expanded_row.tsx
index abc33abcb86..42090f8c6c0 100644
--- a/x-pack/plugins/security/public/management/roles/edit_role/privileges/kibana/feature_table/feature_table_expanded_row.tsx
+++ b/x-pack/plugins/security/public/management/roles/edit_role/privileges/kibana/feature_table/feature_table_expanded_row.tsx
@@ -63,7 +63,8 @@ export const FeatureTableExpandedRow = ({
       privilegeCalculator.updateSelectedFeaturePrivilegesForCustomization(
         feature.id,
         privilegeIndex,
-        e.target.checked
+        e.target.checked,
+        allSpacesSelected
       )
     );
     setIsCustomizing(e.target.checked);
diff --git a/x-pack/plugins/security/public/management/roles/edit_role/privileges/kibana/privilege_form_calculator/privilege_form_calculator.ts b/x-pack/plugins/security/public/management/roles/edit_role/privileges/kibana/privilege_form_calculator/privilege_form_calculator.ts
index d6afdaf6efa..14493fcd561 100644
--- a/x-pack/plugins/security/public/management/roles/edit_role/privileges/kibana/privilege_form_calculator/privilege_form_calculator.ts
+++ b/x-pack/plugins/security/public/management/roles/edit_role/privileges/kibana/privilege_form_calculator/privilege_form_calculator.ts
@@ -185,13 +185,19 @@ export class PrivilegeFormCalculator {
    * @param featureId the feature id
    * @param privilegeIndex  the index of the kibana privileges role component
    * @param willBeCustomizing flag indicating if this feature is about to have its sub-feature privileges customized or not
+   * @param allSpacesSelected indicates if the privilege form is configured to grant access to all spaces.
    */
   public updateSelectedFeaturePrivilegesForCustomization(
     featureId: string,
     privilegeIndex: number,
-    willBeCustomizing: boolean
+    willBeCustomizing: boolean,
+    allSpacesSelected: boolean
   ) {
-    const primary = this.getDisplayedPrimaryFeaturePrivilege(featureId, privilegeIndex);
+    const primary = this.getDisplayedPrimaryFeaturePrivilege(
+      featureId,
+      privilegeIndex,
+      allSpacesSelected
+    );
     const selectedFeaturePrivileges = this.getSelectedFeaturePrivileges(featureId, privilegeIndex);
 
     if (!primary) {

[nchaulet]

/ci

[elasticmachine]

Pinging @elastic/fleet (Team:Fleet)

[nchaulet]

@elasticmachine merge upstream

[juliaElastic]

In the issue it seems we want to exclude None from Settings subfeature, is it possible?

[nchaulet]

In the issue it seems we want to exclude None from Settings subfeature, is it possible?

Looks it does not seems possible to not have None

[juliaElastic]

LGTM, probably we should confirm with Nima, what should be the behaviour if Settings:None is selected.

[nchaulet]

@elasticmachine merge upstream

[kpollich]

Looks great, thanks for setting up the feature flag and getting started here 👍

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: c88ff65

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
fleet	153.8KB	153.8KB	+24.0B

History

• 💚 Build #196701 succeeded 255fce6
• 💛 Build #196633 was flaky e07a45b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet