Fix CDN task assets discovery

[jloleysens]

Summary

Plugin static assets were not being included in the CDN bundle due to the task looking in <plugin_root>/assets. This fix updates the task to look in <plugin_root>/public/assets.

Output structure

tree

❯ tree -dL 3 .
.
└── <hash>
    ├── bundles
    │   ├── core
    │   ├── kbn-monaco
    │   ├── kbn-ui-shared-deps-npm
    │   ├── kbn-ui-shared-deps-src
    │   └── plugin
    ├── plugins
    │   ├── apm
    │   ├── cloudDefend
    │   ├── cloudSecurityPosture
    │   ├── customIntegrations
    │   ├── dashboard
    │   ├── dataViewFieldEditor
    │   ├── discover
    │   ├── enterpriseSearch
    │   ├── fleet
    │   ├── globalSearchBar
    │   ├── home
    │   ├── indexManagement
    │   ├── kibanaOverview
    │   ├── kibanaReact
    │   ├── lens
    │   ├── maps
    │   ├── observability
    │   ├── observabilityAIAssistant
    │   ├── observabilityOnboarding
    │   ├── osquery
    │   ├── remoteClusters
    │   ├── serverlessSearch
    │   └── timelines
    └── ui
        ├── favicons
        └── fonts

35 directories

Test

1. Build distributable using node scripts/build.js to get CDN assets
2. Untar ./target/kibana-8.14.0-SNAPSHOT-cdn-assets.tar.gz
3. Add an entry to /etc/hosts to resolve to 127.0.0.1
4. cd into the untarred folder and serve the assets, I used npx http-server -p 1772 --cors --gzip --brotli
5. Add server.cdn.url: "http://my.cdn.test:1772" to your Kibana config
6. Start Kibana and ES, see assets are loading for the home app from our "CDN"

[elasticmachine]

Pinging @elastic/kibana-operations (Team:Operations)

[jloleysens]

Added assets and buildSha as this was copying into <kibana_root>/plugins

[delanni]

What is this comment intending to communicate?

[jloleysens]

This is the source of where the paths come from... There is a bit of "weak" reference here because these paths are created by Kibana core server-side code at runtime and we are mirroring that code here.

I just followed the pattern in the rest of the file (eg).

Ideally we could share these values by importing some consts or something, but I guess these paths really don't change often so this has been an "OK" way.

[jloleysens]

I'm happy to open a follow up issue!

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 7743827

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jloleysens

[mistic]

@jloleysens should we fix the location of the assets on those 2 plugins in this PR as well?

/src/plugins/guided_onboarding/assets
x-pack/plugins/serverless/assets

[jloleysens]

should we fix the location of the assets on those 2 plugins in this PR as well?

@mistic Yeah, I'm not sure these work given that we only expose assets from public/assets so not sure how they're using these. I'll ask the teams but not sure we should block on that.

---

OK I checked and in both cases assets are either being bundled directly with code (in case of guided_onboarding) or the diagram is from Whimsical and used in README 😄 (in case of serverless)