Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up @ts-expect-error failures from typescript v4.9.5 upgrade #177902

Merged
merged 9 commits into from
Mar 5, 2024
Merged

clean up @ts-expect-error failures from typescript v4.9.5 upgrade #177902

merged 9 commits into from
Mar 5, 2024

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Mar 3, 2024 •
edited
Loading

Closes #176099

Skipped canvas work to limit scope. Canvas changes did not meet definition of "critical bug fixes".

@nreese
Copy link
Contributor Author

nreese commented Mar 3, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Mar 3, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Mar 3, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Mar 3, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Mar 4, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Mar 4, 2024

/ci

@nreese nreese marked this pull request as ready for review March 4, 2024 12:08
@nreese nreese requested review from a team as code owners March 4, 2024 12:08
@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes v8.14.0 labels Mar 4, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese
Copy link
Contributor Author

nreese commented Mar 5, 2024

@elasticmachine merge upstream

@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label Mar 5, 2024
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
maps 1146 1147 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.9MB 2.9MB +173.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

nickpeihl
nickpeihl approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for fixing the types!

code review

@nreese nreese merged commit 894ac3c into elastic:main Mar 5, 2024
18 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickpeihl nickpeihl nickpeihl approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Embedding Embedding content via iFrame release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[presentation] clean up @ts-expect-error failures from typescript v4.9.5 upgrade
5 participants
@nreese @elasticmachine @kibana-ci @nickpeihl @kibanamachine