Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[maps] update ES|QL copy to align with controls copy #177668

Merged
merged 2 commits into from
Feb 24, 2024

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Feb 22, 2024

@teresaalvarezsoler suggested updating ES|QL copy to align with existing controls copy

Controls copy
image

Updated ES|QL copy
Screenshot 2024-02-22 at 4 06 56 PM

@nreese nreese requested a review from a team as a code owner February 22, 2024 23:09
@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes v8.13.0 v8.14.0 labels Feb 22, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

Copy link
Member

@jsanz jsanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nreese nreese requested a review from jsanz February 23, 2024 19:48
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.9MB 2.9MB +12.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit eb8df74 into elastic:main Feb 24, 2024
19 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 24, 2024
@teresaalvarezsoler suggested updating ES|QL copy to align with existing
controls copy

Controls copy

![image](https://github.com/elastic/kibana/assets/373691/976d24a6-6274-44a5-9974-69a533e88983)

Updated ES|QL copy
<img width="300" alt="Screenshot 2024-02-22 at 4 06 56 PM"
src="https://github.com/elastic/kibana/assets/373691/86604d42-771b-439c-ba61-2d5e9bcc7a4a">

(cherry picked from commit eb8df74)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.13

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 24, 2024
…#177769)

# Backport

This will backport the following commits from `main` to `8.13`:
- [[maps] update ES|QL copy to align with controls copy
(#177668)](#177668)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-02-24T11:22:57Z","message":"[maps]
update ES|QL copy to align with controls copy
(#177668)\n\n@teresaalvarezsoler suggested updating ES|QL copy to align
with existing\r\ncontrols copy\r\n\r\nControls
copy\r\n\r\n![image](https://github.com/elastic/kibana/assets/373691/976d24a6-6274-44a5-9974-69a533e88983)\r\n\r\nUpdated
ES|QL copy\r\n<img width=\"300\" alt=\"Screenshot 2024-02-22 at 4 06
56 PM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/373691/86604d42-771b-439c-ba61-2d5e9bcc7a4a\">","sha":"eb8df74e8ecde16ba25d68f603925bdab4859f3a","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","Feature:Maps","v8.13.0","v8.14.0"],"title":"[maps]
update ES|QL copy to align with controls
copy","number":177668,"url":"https://github.com/elastic/kibana/pull/177668","mergeCommit":{"message":"[maps]
update ES|QL copy to align with controls copy
(#177668)\n\n@teresaalvarezsoler suggested updating ES|QL copy to align
with existing\r\ncontrols copy\r\n\r\nControls
copy\r\n\r\n![image](https://github.com/elastic/kibana/assets/373691/976d24a6-6274-44a5-9974-69a533e88983)\r\n\r\nUpdated
ES|QL copy\r\n<img width=\"300\" alt=\"Screenshot 2024-02-22 at 4 06
56 PM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/373691/86604d42-771b-439c-ba61-2d5e9bcc7a4a\">","sha":"eb8df74e8ecde16ba25d68f603925bdab4859f3a"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/177668","number":177668,"mergeCommit":{"message":"[maps]
update ES|QL copy to align with controls copy
(#177668)\n\n@teresaalvarezsoler suggested updating ES|QL copy to align
with existing\r\ncontrols copy\r\n\r\nControls
copy\r\n\r\n![image](https://github.com/elastic/kibana/assets/373691/976d24a6-6274-44a5-9974-69a533e88983)\r\n\r\nUpdated
ES|QL copy\r\n<img width=\"300\" alt=\"Screenshot 2024-02-22 at 4 06
56 PM\"\r\nsrc=\"https://github.com/elastic/kibana/assets/373691/86604d42-771b-439c-ba61-2d5e9bcc7a4a\">","sha":"eb8df74e8ecde16ba25d68f603925bdab4859f3a"}}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <[email protected]>
semd pushed a commit to semd/kibana that referenced this pull request Mar 4, 2024
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Maps release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.13.0 v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants